From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752741AbaE0SEZ (ORCPT ); Tue, 27 May 2014 14:04:25 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:60333 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751477AbaE0SEX (ORCPT ); Tue, 27 May 2014 14:04:23 -0400 From: Stephen Boyd To: Michal Marek Cc: linux-kernel@vger.kernel.org, Mitchel Humpherys , Julia Lawall , Gilles Muller , Nicolas Palix , Grant Likely , Rob Herring , devicetree@vger.kernel.org Subject: [PATCH v2] coccinelle: Check for missing NULL terminators in of_device_id tables Date: Tue, 27 May 2014 11:04:18 -0700 Message-Id: <1401213858-31950-1-git-send-email-sboyd@codeaurora.org> X-Mailer: git-send-email 1.9.0.1.gd5ccf8c Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Failure to terminate an of_device_id table can lead to confusing failures depending on where the compiler places the array. Add a check to make sure these tables are terminated. Thanks to Mitchel Humpherys for coming up with the pattern initially. Cc: Mitchel Humpherys Cc: Julia Lawall Cc: Gilles Muller Cc: Nicolas Palix Cc: Grant Likely Cc: Rob Herring Cc: devicetree@vger.kernel.org Signed-off-by: Stephen Boyd --- scripts/coccinelle/misc/of_table.cocci | 73 ++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) create mode 100644 scripts/coccinelle/misc/of_table.cocci diff --git a/scripts/coccinelle/misc/of_table.cocci b/scripts/coccinelle/misc/of_table.cocci new file mode 100644 index 000000000000..838c74c418c9 --- /dev/null +++ b/scripts/coccinelle/misc/of_table.cocci @@ -0,0 +1,73 @@ +/// Make sure of_device_id tables are NULL terminated +// +// Keywords: of_table +// Confidence: Medium +// Options: --include-headers + +virtual patch +virtual context +virtual org +virtual report + +@bad_of_table exists@ +identifier var, arr; +expression E; +@@ +struct of_device_id arr[] = { + ..., + { + .var = E, + } +}; + +@depends on bad_of_table && context@ +identifier var, arr; +expression E; +@@ +struct of_device_id arr[] = { + ..., + { +* .var = E, + } +}; + +@depends on bad_of_table && patch@ +identifier var, arr; +expression E; +@@ +struct of_device_id arr[] = { + ..., + { + .var = E, +- } ++ }, ++ { } +}; + +@r depends on bad_of_table exists@ +position p1; +identifier var, arr; +expression E; +@@ +struct of_device_id arr[] = { + ..., + { + .var = E, + } + @p1 +}; + +@script:python depends on org@ +p1 << r.p1; +arr << r.arr; +@@ + +cocci.print_main(arr,p1) + +@script:python depends on report@ +p1 << r.p1; +arr << r.arr; +@@ + +msg = "%s is not NULL terminated at line %s" % (arr, p1[0].line) +coccilib.report.print_report(p1[0],msg) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation