public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Cohen <david.a.cohen@intel.com>
To: wim@iguana.be, tglx@linutronix.de, mingo@redhat.com,
	hpa@zytor.com, x86@kernel.org
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
	gnomes@lxorguk.ukuu.org.uk, David Cohen <david.a.cohen@intel.com>
Subject: [PATCH] x86: intel-mid: fix watchdog platform code
Date: Tue, 27 May 2014 14:11:06 -0700	[thread overview]
Message-ID: <1401225066-28786-1-git-send-email-david.a.cohen@intel.com> (raw)
In-Reply-To: <20140526211820.GB23751@spo001.leaseweb.com>

This patch fixes missing include asm/io_apic.h which may lead to
following error:

   arch/x86/platform/intel-mid/device_libs/platform_wdt.c: In function 'tangier_probe':
>> arch/x86/platform/intel-mid/device_libs/platform_wdt.c:37:2: error: implicit declaration of function 'mp_find_ioapic' [-Werror=implicit-function-declaration]
     ioapic = mp_find_ioapic(irq);
     ^
>> arch/x86/platform/intel-mid/device_libs/platform_wdt.c:44:3: error: implicit declaration of function 'io_apic_set_pci_routing' [-Werror=implicit-function-declaration]
      ret = io_apic_set_pci_routing(NULL, irq, &irq_attr);
      ^
Signed-off-by: David Cohen <david.a.cohen@intel.com>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
---
 arch/x86/platform/intel-mid/device_libs/platform_wdt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/platform/intel-mid/device_libs/platform_wdt.c b/arch/x86/platform/intel-mid/device_libs/platform_wdt.c
index a05315eb052d..973cf3bfa9fd 100644
--- a/arch/x86/platform/intel-mid/device_libs/platform_wdt.c
+++ b/arch/x86/platform/intel-mid/device_libs/platform_wdt.c
@@ -15,6 +15,7 @@
 #include <linux/platform_device.h>
 #include <linux/platform_data/intel-mid_wdt.h>
 #include <asm/intel-mid.h>
+#include <asm/io_apic.h>
 
 #define TANGIER_EXT_TIMER0_MSI 15
 
-- 
1.9.1


       reply	other threads:[~2014-05-27 21:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20140526211820.GB23751@spo001.leaseweb.com>
2014-05-27 21:11 ` David Cohen [this message]
2014-05-27 21:21   ` [PATCH] x86: intel-mid: fix watchdog platform code David Cohen
2014-05-27 23:34     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401225066-28786-1-git-send-email-david.a.cohen@intel.com \
    --to=david.a.cohen@intel.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=wim@iguana.be \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox