From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Paul Bolle <pebolle@tiscali.nl>,
Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] acornscsi: remove linked command support
Date: Wed, 28 May 2014 18:26:44 +0400 [thread overview]
Message-ID: <1401287204.2288.28.camel@dabdike> (raw)
In-Reply-To: <20140528104114.GE13542@infradead.org>
On Wed, 2014-05-28 at 03:41 -0700, Christoph Hellwig wrote:
> On Sat, May 24, 2014 at 12:13:53PM +0200, Paul Bolle wrote:
> > The acornscsi driver was added in v2.1.88. It has always #undef-ed
> > CONFIG_SCSI_ACORNSCSI_LINK near the top of acornscsi.c. And, just to be
> > sure, it has also always triggered a preprocessor error if
> > CONFIG_SCSI_ACORNSCSI_LINK was still defined. But, as far as I can see,
> > it has never even been possible to set SCSI_ACORNSCSI_LINK through
> > kconfig, or its predecessors, in the first place.
> >
> > Let's remove the code involved.
> >
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
>
> Looks good,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> And I have to disagree with James here, removing code that isn't even
> compiled always is an improvement, especially for an unmaintained
> driver.
Well, as I said, this is in theory a maintained driver, so just get an
ack from Russell and this debate is moot.
James
next prev parent reply other threads:[~2014-05-28 14:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-24 10:13 [PATCH] acornscsi: remove linked command support Paul Bolle
2014-05-24 10:35 ` Hannes Reinecke
2014-05-24 12:13 ` James Bottomley
2014-05-24 13:16 ` Paul Bolle
2014-05-25 7:42 ` James Bottomley
2014-05-28 17:28 ` Paul Bolle
2014-05-28 10:41 ` Christoph Hellwig
2014-05-28 14:26 ` James Bottomley [this message]
2014-05-28 15:17 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401287204.2288.28.camel@dabdike \
--to=james.bottomley@hansenpartnership.com \
--cc=hch@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox