Re: [PATCH v2 2/2] audit: Mark CONFIG_AUDITSYSCALL BROKEN and update help text

Steve Grubb
2014-05-29T13:05:22Z

On Wednesday, May 28, 2014 07:40:57 PM Andy Lutomirski wrote:
> >> - It assumes that syscall numbers are between 0 and 2048.
> >>
> > There could well be a bug here. Not questioning that. Although that
> > would be patch 1/2
>
> Even with patch 1, it still doesn't handle large syscall numbers -- it
> just assumes they're not audited.

All syscalls must be auditable. Meaning that if an arch goes above 2048, then
we'll need to do some math to get it to fall back within the range.

> >> - It's unclear whether it's supposed to be reliable.
> >>
> > Unclear to whom?
>
> To me.
>
> If some inode access or selinux rule triggers an audit, is the auditsc
> code guaranteed to write an exit record? And see below...

It should or indicate that it could not.

-Steve