From: Scott Wood <scottwood@freescale.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Vitaly Bordug <vitb@kernel.crashing.org>,
Marcelo Tosatti <marcelo@kvack.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
<linux-pcmcia@lists.infradead.org>,
<linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
Vitaly Bordug <vitb@kernel.crashing.org>
Subject: Re: [PATCH] pcmcia: m8xx: remove checks for four macros
Date: Thu, 29 May 2014 13:20:24 -0500 [thread overview]
Message-ID: <1401387624.6603.161.camel@snotra.buserror.net> (raw)
In-Reply-To: <1400916970.31526.78.camel@x220>
On Sat, 2014-05-24 at 09:36 +0200, Paul Bolle wrote:
> This driver contains checks for four Kconfig macros. But the related
> Kconfig symbols have never been part of the tree. Remove these checks
> and the code they hide.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Untested.
>
> This has been an issue ever since this driver was added in v2.6.15. Note
> that there is no header named "*/cpld.h", so setting PRxK can't possibly
> work.
>
> drivers/pcmcia/m8xx_pcmcia.c | 75 --------------------------------------------
> 1 file changed, 75 deletions(-)
Does anything in this driver still work? It looks like bitrot from the
arch/ppc days, that sort of got updated to use the device tree -- but
even after this patch there are lots of instances of CONFIG symbols
being used to assert the exact hardware being used, rather than what
hardware is supported.
Is anyone actively maintaining/testing this code?
-Sott
next prev parent reply other threads:[~2014-05-29 18:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-24 7:36 [PATCH] pcmcia: m8xx: remove checks for four macros Paul Bolle
2014-05-24 7:41 ` Paul Bolle
2014-05-29 18:20 ` Scott Wood [this message]
2014-05-29 18:39 ` Paul Bolle
2014-05-29 18:42 ` Scott Wood
2014-05-29 19:04 ` Paul Bolle
2014-05-29 21:28 ` [PATCH] PPC: 8xx: update MAINTAINERS entry Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401387624.6603.161.camel@snotra.buserror.net \
--to=scottwood@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=marcelo@kvack.org \
--cc=paulus@samba.org \
--cc=pebolle@tiscali.nl \
--cc=vitb@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox