From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755938AbaE3Mqb (ORCPT ); Fri, 30 May 2014 08:46:31 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:53493 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752186AbaE3Mq3 (ORCPT ); Fri, 30 May 2014 08:46:29 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfec7f5-b7f626d000004b39-ed-53887da1df5b Content-transfer-encoding: 8BIT Message-id: <1401453990.11651.2.camel@AMDC1943> Subject: Re: [PATCH] ARM: exynos4212: hotplug: Fix CPU idle clock down after CPU1 off From: Krzysztof Kozlowski To: Tomasz Figa Cc: Russell King , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz , Tomasz Figa Date: Fri, 30 May 2014 14:46:30 +0200 In-reply-to: <53887095.7090108@gmail.com> References: <1399990378-7023-1-git-send-email-k.kozlowski@samsung.com> <53887095.7090108@gmail.com> X-Mailer: Evolution 3.10.4-0ubuntu1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJLMWRmVeSWpSXmKPExsVy+t/xq7oLazuCDX4st7TYOGM9q0Xvgqts Fmeb3rBbbHp8jdXi8q45bBYzzu9jsrh9mddi7ZG77BbrZ7xmsVi16w+jA5dHS3MPm8fOWXfZ PTYvqffo27KK0ePzJrkA1igum5TUnMyy1CJ9uwSujEdzP7IXfBeu6G1bzdbAeIG/i5GTQ0LA ROL2z12sELaYxIV769m6GLk4hASWMkosnfqEHSTBKyAo8WPyPZYuRg4OZgF5iSOXskHCzALq EpPmLWKGqP/MKPF40kwmkBpeAX2JT1/cQWqEBcIl3i65yQhiswkYS2xevoQNxBYB6v02pZ8d pJdZ4B2TxNNJb1lAEiwCqhKXWqeDHcQpoCnx5t95JhBbSCBV4u/ndqhDlSXm7T/GNIFRYBaS 82YhnDcLyXkLGJlXMYqmliYXFCel5xrpFSfmFpfmpesl5+duYoQE/9cdjEuPWR1iFOBgVOLh zXBpDxZiTSwrrsw9xCjBwawkwptW2BEsxJuSWFmVWpQfX1Sak1p8iJGJg1OqgXGyBePaUPbS 562L2syLr+d4/XdIUI86oqoWW1uxz/HdZ/FzPAG8d23U+yak+DJIGp3dXim6LuaKVf/mBdtZ lylsYOMWmhMbvbV+93QZTjZr9989W6cdWrpQfdOtsnk/563ctqZL/0XZ5keKFsrLF+gbPMy/ +u/kQn4rUa9Vmud0H3669O/y/m1KLMUZiYZazEXFiQDgAhURXAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On pią, 2014-05-30 at 13:50 +0200, Tomasz Figa wrote: > Hi Krzysztof, > > On 13.05.2014 16:12, Krzysztof Kozlowski wrote: > > On Exynos4212 USE_DELAYED_RESET_ASSERTION must be set in > > ARM_CORE1_OPTION register during CPU power down. This is the proper way > > of powering down CPU. Additionally without this the CPU clock down won't > > work after powering down CPU1 and CPU will work at full frequency chosen > > by CPUfreq governor. > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > arch/arm/mach-exynos/hotplug.c | 28 +++++++++++++++++++++++++--- > > arch/arm/mach-exynos/regs-pmu.h | 2 ++ > > 2 files changed, 27 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c > > index 5eead530c6f8..59b813e74558 100644 > > --- a/arch/arm/mach-exynos/hotplug.c > > +++ b/arch/arm/mach-exynos/hotplug.c > > @@ -74,7 +74,7 @@ static inline void cpu_enter_lowpower_a15(void) > > dsb(); > > } > > > > -static inline void cpu_leave_lowpower(void) > > +static inline void cpu_leave_lowpower(unsigned int cpu) > > { > > unsigned int v; > > > > @@ -88,6 +88,14 @@ static inline void cpu_leave_lowpower(void) > > : "=&r" (v) > > : "Ir" (CR_C), "Ir" (0x40) > > : "cc"); > > + > > + if (cpu == 1 && soc_is_exynos4212()) { > > AFAIK this is needed not only on Exynos4x12, but at least also on 4412. > Also I don't think the (cpu == 1) condition is necessary. See below. I'll test it on Exynos4412. > > > + unsigned int tmp; > > + > > + tmp = __raw_readl(S5P_ARM_CORE1_OPTION); > > + tmp &= ~(S5P_USE_DELAYED_RESET_ASSERTION); > > + __raw_writel(tmp, S5P_ARM_CORE1_OPTION); > > + } > > } > > > > static inline void platform_do_lowpower(unsigned int cpu, int *spurious) > > @@ -95,8 +103,22 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious) > > for (;;) { > > > > /* make cpu1 to be turned off at next WFI command */ > > - if (cpu == 1) > > + if (cpu == 1) { > > I think this patch should be rebased on top of my "[PATCH] ARM: EXYNOS: > Fix core ID used by platsmp and hotplug code". Then instead of if (cpu > == 1) you would just use EXYNOS_ARM_CORE_OPTION(core_id). > > Also same comment as above, I believe this is also needed on Exynos4412. Probably your patch needs rebasing too. I couldn't apply (cleanly) on current Linus' tree and on Kukjin's for-next. What are the requirements for it? Best regards, Krzysztof