Re: [PATCH 1/5] mfd: arizona: Disable PM runtime at start of driver removal

Lee Jones
2014-06-17T14:33:41Z

> We don't want to trigger any PM runtime operations whilst we are tearing
> down the driver, as things the suspend and resume callbacks rely on
> might already have been destroyed. So disable PM runtime for the device
> as the first step arizona_dev_exit.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/arizona-core.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index cabe8f4..7bdc0f5 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -1024,11 +1024,12 @@ EXPORT_SYMBOL_GPL(arizona_dev_init);
>
> int arizona_dev_exit(struct arizona *arizona)
> {
> + pm_runtime_disable(arizona->dev);
> +
> mfd_remove_devices(arizona->dev);
> arizona_free_irq(arizona, ARIZONA_IRQ_UNDERCLOCKED, arizona);
> arizona_free_irq(arizona, ARIZONA_IRQ_OVERCLOCKED, arizona);
> arizona_free_irq(arizona, ARIZONA_IRQ_CLKGEN_ERR, arizona);
> - pm_runtime_disable(arizona->dev);
> arizona_irq_exit(arizona);
> if (arizona->pdata.reset)
> gpio_set_value_cansleep(arizona->pdata.reset, 0);

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog