Re: [PATCH v5 00/15] Thunderbolt driver for Apple MacBooks

Greg KH
2014-06-03T20:30:16Z

On Tue, Jun 03, 2014 at 10:03:57PM +0200, Andreas Noever wrote:
> Hi,
>
> Updated version of the driver. Includes changes by Matthew to make it work on
> Falcon Ridge hardware (present in the newest Mac(Book)Pro).
>
> Changes since v4 (suggested by Matthew):
> - Changed the PCI quirks to check just for Apple hardware instead of checking
> against a list of machines. (The PCI id check already restricts this quirk
> to the relevant Apple machines).
> - Added Falcon Ridge PCI id to the driver and to the "wait_for_thunderbolt"
> quirk (the "poweroff_thunderbolt" quirk is no longer necessary for Falcon
> Ridge devices).
> - Fixed plug events for Falcon Ridge hardware.
>
> @Matthew: I think that your patch was missing the Falcon Ridge PCI id within
> the wait_for_thunderbolt quirk (I have added it). If you have time could you
> verify that suspend/resume works on your MacPro? Thanks!
>
> As before Matthew's ACPI changes (latest version: [1]) are required for this to
> work properly. Without them you need to boot with a coldplugged TB device to
> prevent the firmware from disabling the controller.

Looks good, I'll queue these up to my tree after 3.16-rc1 is out unless
anyone finds any problems with them before then.

thanks,

greg k-h