Re: [PATCH v5 01/15] thunderbolt: Add initial cactus ridge NHI support

Andreas Noever
2014-06-20T19:46:10Z

On Fri, Jun 20, 2014 at 9:41 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
> On Tue, 2014-06-03 at 22:03 +0200, Andreas Noever wrote:
>> Thunderbolt hotplug is supposed to be handled by the firmware. But Apple
>> decided to implement thunderbolt at the operating system level. The
>> firmare only initializes thunderbolt devices that are present at boot
>> time. This driver enables hotplug of thunderbolt of non-chained
>> thunderbolt devices on Apple systems with a cactus ridge controller.
>>
>> This first patch adds the Kconfig file as well the parts of the driver
>> which talk directly to the hardware (that is pci device setup, interrupt
>> handling and RX/TX ring management).
>>
>> Signed-off-by: Andreas Noever <andreas.noever@gmail.com>
>> ---
>
> This patch landed in today's linux-next (next-20140620).
>
>> [...]
>> --- /dev/null
>> +++ b/drivers/thunderbolt/Kconfig
>> @@ -0,0 +1,12 @@
>> +menuconfig THUNDERBOLT
>> + tristate "Thunderbolt support for Apple devices"
>> + default no
>
> That should have been "default n". But "n" is the default anyway, so I'd
> say this line might as well be dropped. Should I draft the trivial patch
> to do that?

Not necessary. A patch has already been send.

Andreas