From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755406AbaFCWtT (ORCPT ); Tue, 3 Jun 2014 18:49:19 -0400 Received: from smtprelay0155.hostedemail.com ([216.40.44.155]:56665 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751955AbaFCWtS (ORCPT ); Tue, 3 Jun 2014 18:49:18 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:973:982:988:989:1260:1261:1277:1311:1313:1314:1345:1359:1373:1431:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2110:2393:2553:2559:2562:2693:2828:2892:3138:3139:3140:3141:3142:335 X-HE-Tag: head44_6dc89afa3b10f X-Filterd-Recvd-Size: 3453 Message-ID: <1401835748.22133.13.camel@joe-AO725> Subject: Re: [PATCH v2 RFC 1/3] MAINTAINERS: Add "R:" designated-reviewers tag From: Joe Perches To: paulmck@linux.vnet.ibm.com Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com, sbw@mit.edu Date: Tue, 03 Jun 2014 15:49:08 -0700 In-Reply-To: <20140603214809.GX22231@linux.vnet.ibm.com> References: <1401809736-12023-1-git-send-email-paulmck@linux.vnet.ibm.com> <1401822187.18833.24.camel@joe-AO725> <20140603201202.GW22231@linux.vnet.ibm.com> <1401826567.22133.2.camel@joe-AO725> <20140603214809.GX22231@linux.vnet.ibm.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.10.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2014-06-03 at 14:48 -0700, Paul E. McKenney wrote: > On Tue, Jun 03, 2014 at 01:16:07PM -0700, Joe Perches wrote: > > On Tue, 2014-06-03 at 13:12 -0700, Paul E. McKenney wrote: > > > On Tue, Jun 03, 2014 at 12:03:07PM -0700, Joe Perches wrote: > > > > On Tue, 2014-06-03 at 08:35 -0700, Paul E. McKenney wrote: > > > > > Paul Walmsley also noted the need for patch > > > > > submitters to know who the key reviewers are and suggested adding an > > > > > "R:" tag to the MAINTAINERS file to record this information on a > > > > > per-subsystem basis. > > > > [] > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > [] > > > > > @@ -70,6 +70,8 @@ Descriptions of section entries: > > > > > > > > > > P: Person (obsolete) > > > > > M: Mail patches to: FullName > > > > > + R: Designated reviewer, who should be CCed on patches, > > > > > + format: FullName > > > > > L: Mailing list that is relevant to this area > > > > > W: Web-page with status/info > > > > > Q: Patchwork web based patch tracking system site > > > > > > > > Perhaps the M: and R: roles should be more fully > > > > described here. > > > > > > > > The R: entry description doesn't need commas. > > > > > > > > Maybe something like: > > > > M: Maintainer (to:) FullName > > > > R: Reviewer (cc:) FullName > > > > > > This is arguably better organized, but I need to keep my focus on adding > > > the designated reviewer. I am not in a position to undertake a rewrite > > > of the MAINTAINER file preamble at this point. > > > > That's silly, you're adding the "R" entry. > > Add a proper description for it. > > I will take another look at R: in a few days and possibly wordsmith it. Swell, thanks. > My reluctance is due to the fact that this will change how newbies > submit patches. Very, very doubtful that will change. > But if we get a few Acked-by or Reviewed-by responses > from high-level maintainers (Linus, Greg, Ingo, Thomas, Peter, Ted, > Dave, Ben, ...), I will of course be happy to queue it. cheers, Joe