From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933248AbaFIKWt (ORCPT ); Mon, 9 Jun 2014 06:22:49 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:32583 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932611AbaFIKWq (ORCPT ); Mon, 9 Jun 2014 06:22:46 -0400 X-AuditID: cbfec7f5-b7f626d000004b39-df-53958af3fc36 Message-id: <1402309361.17650.14.camel@AMDC1943> Subject: Re: [PATCH 1/5] mfd: Add driver for Maxim 77802 Power Management IC From: Krzysztof Kozlowski To: Javier Martinez Canillas Cc: Lee Jones , Alessandro Zummo , Kukjin Kim , Mike Turquette , Samuel Ortiz , Tomeu Vizoso , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood , Doug Anderson , linux-samsung-soc@vger.kernel.org, Sjoerd Simons , Mark Brown , Olof Johansson , linux-arm-kernel@lists.infradead.org, Daniel Stone Date: Mon, 09 Jun 2014 12:22:41 +0200 In-reply-to: <1402306670-17041-2-git-send-email-javier.martinez@collabora.co.uk> References: <1402306670-17041-1-git-send-email-javier.martinez@collabora.co.uk> <1402306670-17041-2-git-send-email-javier.martinez@collabora.co.uk> Content-type: text/plain; charset=UTF-8 X-Mailer: Evolution 3.10.4-0ubuntu1 MIME-version: 1.0 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAIsWRmVeSWpSXmKPExsVy+t/xy7qfu6YGG3zbo2mx5OJVdoupD5+w WWzq38puMf/IOVaLs8sOslkc/V1g0bvgKpvF/a9HGS2+Xelgstj0+BqrxeVdc9gsZpzfx2Tx dMJFNotT1z+zWZzuZrWYfvwtq0Xf2ktsDoIesxsusnj8fX6dxWPH3SWMHjtn3WX32LSqk83j zrU9bB7zTgZ6bF5S73HlRBOrR9+WVYwe0+f9ZPL4vEkugCeKyyYlNSezLLVI3y6BK+PrlxbW gjuyFYumzGZrYFwj0cXIySEhYCJxfOFLdghbTOLCvfVsXYxcHEICSxklFpy8xgrhfGaUOPD3 KVgVr4CBRG/rU0YQW1jAR+LQtmNsIDabgLHE5uVLwGwRATuJG6sfMoM0Mws8YJF4svwVWIJF QFXi3LzrQFM5ODgFAiRWHE2EWDCVUeLEs81MIDXMAuoSk+YtYoY4SVli3v5jTBCLBSV+TL7H AlEjL7F5zVvmCYwCs5C0zEJSNgtJ2QJG5lWMoqmlyQXFSem5RnrFibnFpXnpesn5uZsYIbH4 dQfj0mNWhxgFOBiVeHgTmKYGC7EmlhVX5h5ilOBgVhLh9ckBCvGmJFZWpRblxxeV5qQWH2Jk 4uCUamDkuvfMWeL2g469SQfuCX1VOrXu4Kwj52Jv7m1qFdNP0P50iEvE36cxeHEtrwaTWIpl 9rxbYX8MMg4eubhCI/uT2tPrH9NWaqXMYMtrmGPRFpEu7ilvrNry/PTO2ULqqc8rXmy0yKtP +pK02qrP/6NI6ATXU4uOHlww59AZWY7UBxLnWFOPP+9XYinOSDTUYi4qTgQAwK1LTaMCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On pon, 2014-06-09 at 11:37 +0200, Javier Martinez Canillas wrote: > Maxim MAX77802 is a power management chip that contains 10 high > efficiency Buck regulators, 32 Low-dropout (LDO) regulators used > to power up application processors and peripherals, a 2-channel > 32kHz clock outputs, a Real-Time-Clock (RTC) and a I2C interface > to program the individual regulators, clocks outputs and the RTC. > > This patch adds the core support for MAX77802 PMIC and is based > on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree. > > Signed-off-by: Javier Martinez Canillas (...) > diff --git a/drivers/mfd/max77802-irq.c b/drivers/mfd/max77802-irq.c > new file mode 100644 > index 0000000..38a8ce7 > --- /dev/null > +++ b/drivers/mfd/max77802-irq.c > @@ -0,0 +1,332 @@ > +/* > + * max77802-irq.c - Interrupt controller support for MAX77802 > + * > + * Copyright (C) 2013-2014 Google, Inc > + * > + * Copyright (C) 2012 Samsung Electronics Co.Ltd > + * Chiwoong Byun > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * This driver is based on max8997-irq.c > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +enum { > + MAX77802_DEBUG_IRQ_INFO = 1 << 0, > + MAX77802_DEBUG_IRQ_MASK = 1 << 1, > + MAX77802_DEBUG_IRQ_INT = 1 << 2, > +}; > + > +static int debug_mask = 0; > +module_param(debug_mask, int, 0); > +MODULE_PARM_DESC(debug_mask, "Set debug_mask : 0x0=off 0x1=IRQ_INFO 0x2=IRQ_MASK 0x4=IRQ_INI)"); > + > +static const u8 max77802_mask_reg[] = { > + [PMIC_INT1] = MAX77802_REG_INT1MSK, > + [PMIC_INT2] = MAX77802_REG_INT2MSK, > + [RTC_INT] = MAX77802_RTC_INTM, > +}; > + > +struct max77802_irq_data { > + int mask; > + enum max77802_irq_source group; > +}; > + > +#define DECLARE_IRQ(idx, _group, _mask) \ > + [(idx)] = { .group = (_group), .mask = (_mask) } > +static const struct max77802_irq_data max77802_irqs[] = { > + DECLARE_IRQ(MAX77802_PMICIRQ_PWRONF, PMIC_INT1, 1 << 0), > + DECLARE_IRQ(MAX77802_PMICIRQ_PWRONR, PMIC_INT1, 1 << 1), > + DECLARE_IRQ(MAX77802_PMICIRQ_JIGONBF, PMIC_INT1, 1 << 2), > + DECLARE_IRQ(MAX77802_PMICIRQ_JIGONBR, PMIC_INT1, 1 << 3), > + DECLARE_IRQ(MAX77802_PMICIRQ_ACOKBF, PMIC_INT1, 1 << 4), > + DECLARE_IRQ(MAX77802_PMICIRQ_ACOKBR, PMIC_INT1, 1 << 5), > + DECLARE_IRQ(MAX77802_PMICIRQ_ONKEY1S, PMIC_INT1, 1 << 6), > + DECLARE_IRQ(MAX77802_PMICIRQ_MRSTB, PMIC_INT1, 1 << 7), > + DECLARE_IRQ(MAX77802_PMICIRQ_140C, PMIC_INT2, 1 << 0), > + DECLARE_IRQ(MAX77802_PMICIRQ_120C, PMIC_INT2, 1 << 1), > + DECLARE_IRQ(MAX77802_RTCIRQ_RTC60S, RTC_INT, 1 << 0), > + DECLARE_IRQ(MAX77802_RTCIRQ_RTCA1, RTC_INT, 1 << 1), > + DECLARE_IRQ(MAX77802_RTCIRQ_RTCA2, RTC_INT, 1 << 2), > + DECLARE_IRQ(MAX77802_RTCIRQ_SMPL, RTC_INT, 1 << 3), > + DECLARE_IRQ(MAX77802_RTCIRQ_RTC1S, RTC_INT, 1 << 4), > + DECLARE_IRQ(MAX77802_RTCIRQ_WTSR, RTC_INT, 1 << 5), > +}; Why just not use two regmap_irq_chips (for PMIC and RTC blocks) replacing whole max77802-irq.c file? Best regards, Krzysztof