From: Kirill Tkhai <ktkhai@parallels.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
<tkhai@yandex.ru>
Subject: Re: [PATCH 1/2] sched: Rework migrate_tasks()
Date: Wed, 11 Jun 2014 15:15:37 +0400 [thread overview]
Message-ID: <1402485337.32126.29.camel@tkhai> (raw)
In-Reply-To: <20140611105733.GM6758@twins.programming.kicks-ass.net>
В Ср, 11/06/2014 в 12:57 +0200, Peter Zijlstra пишет:
> On Wed, Jun 11, 2014 at 01:52:10PM +0400, Kirill Tkhai wrote:
> >
> > Currently migrate_tasks() skips throttled tasks,
> > because they are not pickable by pick_next_task().
> >
> > These tasks stay on dead cpu even after they
> > becomes unthrottled. They are not schedulable
> > till user manually changes their affinity or till
> > cpu becomes alive again.
> >
> > But for user this looks completely untransparent:
> > task hangs, but it's not obvious what he has to do,
> > because kernel does not report any problem.
> >
> > This situation may easily be triggered intentionally.
> > Playing with extremely small cpu.cfs_quota_us causes
> > it almost in 100% cases. In usual life it's very rare,
> > but still possible for some unhappy user.
> >
>
> How about fixing the unthrottle code to validate the affinity?
I've begun that before, but found, it requires much more code
(three classes need this fix).
And this makes unthrottle code a little ugly (in my view).
Kirill
next prev parent reply other threads:[~2014-06-11 11:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140611093417.27807.2288.stgit@tkhai>
2014-06-11 9:52 ` [PATCH 1/2] sched: Rework migrate_tasks() Kirill Tkhai
2014-06-11 10:57 ` Peter Zijlstra
2014-06-11 11:15 ` Kirill Tkhai [this message]
2014-06-11 11:24 ` Srikar Dronamraju
2014-06-11 12:20 ` Kirill Tkhai
2014-06-11 13:15 ` Srikar Dronamraju
2014-06-11 13:43 ` Kirill Tkhai
2014-06-11 19:33 ` Kirill Tkhai
2014-06-12 2:05 ` Mike Galbraith
2014-06-17 12:56 ` Kirill Tkhai
2014-06-11 9:52 ` [PATCH 2/2] sched: Rework check_for_tasks() Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402485337.32126.29.camel@tkhai \
--to=ktkhai@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tkhai@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox