From: Jean Delvare <jdelvare@suse.de>
To: guillaume.gardet@free.fr
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Sachin Kamat <sachin.kamat@samsung.com>,
linux-kernel@vger.kernel.org,
openSUSE Kernel ML <opensuse-kernel@opensuse.org>,
Girish K S <ks.giri@samsung.com>,
Yuvaraj C D <yuvaraj.cd@samsung.com>,
Sachin Kamat <spk.linux@gmail.com>
Subject: Re: [PATCH] phy: Fix typo in drivers/phy/phy-exynos5250-sata.c module which fixes the build
Date: Thu, 12 Jun 2014 12:01:59 +0200 [thread overview]
Message-ID: <1402567319.4564.2.camel@chaos.site> (raw)
In-Reply-To: <53997666.7000003@free.fr>
Le Thursday 12 June 2014 à 11:44 +0200, Guillaume Gardet a écrit :
> Le 12/06/2014 11:03, Kishon Vijay Abraham I a écrit :
> >
> > On Thursday 12 June 2014 02:14 PM, Guillaume Gardet wrote:
> >> Le 12/06/2014 10:36, Sachin Kamat a écrit :
> >>> Hi Guillaume,
> >>>
> >>>
> >>> On Thu, Jun 12, 2014 at 1:48 PM, Guillaume Gardet
> >>> <guillaume.gardet@free.fr> wrote:
> >>>> Hi,
> >>>>
> >>>> please find in attachment a patch which fixes a typo in drivers/phy/phy-exynos5250-sata.c module license.
> >>>> It fixes the following build error:
> >>>> FATAL: modpost: GPL-incompatible module phy-exynos5250-sata.ko uses GPL-only symbol 'platform_driver_unregister'
> >>>>
> >>>> Please keep me in CC since I am not subscribed to the linux-kernel@vger.kernel.org ML.
> >>>>
> >>>> Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
> >>> A similar patch has already been submitted by Arnd. Please see below:
> >>> https://lkml.org/lkml/2014/3/15/40
> >> Was not aware of this one. Will it be merged? I can see that it was sent 3 months ago and got no answer apparently.
> > It's in mainline kernel already
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/phy/phy-exynos5250-sata.c?id=fe04e4297e6eab014a2cf152319b9f361df07faf
>
> Ok. It is in mainline but not in 3.15.
And as it stands, it won't be, because stable@vger.kernel.org was not
Cc'd. "Typo" in the subject makes it sound like a trivial and minor
change. "Fix module loading" would probably have made it clearer that it
fixes a real issue.
Guillaume, if this bothers you, please write to stable@vger.kernel.org
and kindly ask them to consider including this commit in future stable
releases.
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2014-06-12 10:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 8:18 [PATCH] phy: Fix typo in drivers/phy/phy-exynos5250-sata.c module which fixes the build Guillaume Gardet
2014-06-12 8:36 ` Sachin Kamat
2014-06-12 8:44 ` Guillaume Gardet
2014-06-12 9:03 ` Kishon Vijay Abraham I
2014-06-12 9:44 ` Guillaume Gardet
2014-06-12 9:48 ` Kishon Vijay Abraham I
2014-06-12 10:01 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402567319.4564.2.camel@chaos.site \
--to=jdelvare@suse.de \
--cc=guillaume.gardet@free.fr \
--cc=kishon@ti.com \
--cc=ks.giri@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=opensuse-kernel@opensuse.org \
--cc=sachin.kamat@samsung.com \
--cc=spk.linux@gmail.com \
--cc=yuvaraj.cd@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox