Re: [RFC 1/9] of/irq: Rename of_irq_map_* functions to of_irq_parse_*

Michal Simek
2013-10-16T10:47:46Z

[-- Attachment #1: Type: text/plain, Size: 2865 bytes --]

On 10/15/2013 10:39 PM, Grant Likely wrote:
> The OF irq handling code has been overloading the term 'map' to refer to
> both parsing the data in the device tree and mapping it to the internal
> linux irq system. This is probably because the device tree does have the
> concept of an 'interrupt-map' function for translating interrupt
> references from one node to another, but 'map' is still confusing when
> the primary purpose of some of the functions are to parse the DT data.
>
> This patch renames all the of_irq_map_* functions to of_irq_parse_*
> which makes it clear that there is a difference between the parsing
> phase and the mapping phase. Kernel code can make use of just the
> parsing or just the mapping support as needed by the subsystem.
>
> The patch was generated mechanically with a handful of sed commands.
>
> Signed-off-by: Grant Likely <grant.likely@linaro.org>
> Cc: Michal Simek <monstr@monstr.eu>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> arch/arm/mach-integrator/pci_v3.c | 4 ++--
> arch/microblaze/pci/pci-common.c | 2 +-
> arch/mips/pci/fixup-lantiq.c | 2 +-
> arch/mips/pci/pci-rt3883.c | 2 +-
> arch/powerpc/kernel/pci-common.c | 2 +-
> arch/powerpc/platforms/cell/celleb_scc_pciex.c | 2 +-
> arch/powerpc/platforms/cell/celleb_scc_sio.c | 2 +-
> arch/powerpc/platforms/cell/spider-pic.c | 2 +-
> arch/powerpc/platforms/cell/spu_manage.c | 2 +-
> arch/powerpc/platforms/fsl_uli1575.c | 2 +-
> arch/powerpc/platforms/powermac/pic.c | 2 +-
> arch/powerpc/platforms/pseries/event_sources.c | 2 +-
> arch/powerpc/sysdev/mpic_msi.c | 2 +-
> arch/x86/kernel/devicetree.c | 2 +-
> drivers/of/address.c | 4 ++--
> drivers/of/irq.c | 28 +++++++++++++-------------
> drivers/of/of_pci_irq.c | 10 ++++-----
> drivers/pci/host/pci-mvebu.c | 2 +-
> include/linux/of_irq.h | 8 ++++----
> include/linux/of_pci.h | 2 +-
> 20 files changed, 42 insertions(+), 42 deletions(-)

I have go through microblaze changes in this series and all are fine.

For Microblaze changes. I expect you have already compiled that
without any warning.

Acked-by: Michal Simek <monstr@monstr.eu>

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]