Re: [RFC 4/9] of/irq: Refactor interrupt-map parsing

Olof Johansson
2013-11-04T05:05:16Z

On Fri, Nov 01, 2013 at 11:54:01AM -0700, Grant Likely wrote:
> On Fri, 01 Nov 2013 10:53:17 -0700, Grant Likely <grant.likely@linaro.org> wrote:
> > On Thu, 31 Oct 2013 11:57:14 -0700, Olof Johansson <olof@lixom.net> wrote:
> > > On Wed, Oct 30, 2013 at 02:25:21PM -0700, Grant Likely wrote:
> > > > (Sorry for HTML mail)
> > > >
> > > > Can you put #define DEBUG at the top of drivers/of/irq.c and send me the
> > > > log output from before and after the commit?
> > >
> > > Here you go, quite verbose log below.
> > >
> > > Looks like we're tripping the "no reg passed in" checks, not sure if related.
> >
> > I think I've found the bug. See if this helps...
>
> That one was broken. Try this instead.
>
> From bcbffc3d16f49451ef505dc021480aa061465a15 Mon Sep 17 00:00:00 2001
> From: Grant Likely <grant.likely@linaro.org>
> Date: Fri, 1 Nov 2013 10:50:50 -0700
> Subject: [PATCH] of: Fixup interrupt parsing failure.
>
> Signed-off-by: Grant Likely <grant.likely@linaro.org>

Well, it boots. That's an improvement. :) It is again going for the
precalculated delay loop. I'm not sure why the code path diverged before,
especially given the below irq request fail for MCT.

I do see a bunch of new printk errors that I didn't use to though:

[ 0.000000] genirq: Flags mismatch irq 160. 00015200 (mct_comp_irq) vs. 00014a00 (mct_tick0)
[ 0.040401] genirq: Flags mismatch irq 160. 00014a00 (mct_tick1) vs. 00014a00 (mct_tick0)
[ 0.040405] exynos-mct: cannot register IRQ 160

So I don't think we're home safe yet. I need to spend some time this week
actually debugging this... Good thing the merge window is delayed.

-Olof