Re: [RFC 9/9] of/irq: create interrupts-extended property

Grant Likely
2013-10-29T00:09:36Z

On Mon, 28 Oct 2013 01:54:38 -0500, Kumar Gala <galak@codeaurora.org> wrote:
>
> On Oct 15, 2013, at 3:39 PM, Grant Likely wrote:
>
> > The standard interrupts property in device tree can only handle
> > interrupts coming from a single interrupt parent. If a device is wired
> > to multiple interrupt controllers, then it needs to be attached to a
> > node with an interrupt-map property to demux the interrupt specifiers
> > which is confusing. It would be a lot easier if there was a form of the
> > interrupts property that allows for a separate interrupt phandle for
> > each interrupt specifier.
> >
> > This patch does exactly that by creating a new interrupts-extended
> > property which reuses the phandle+arguments pattern used by GPIOs and
> > other core bindings.
> >
> > Signed-off-by: Grant Likely <grant.likely@linaro.org>
> > Cc: Rob Herring <rob.herring@calxeda.com>
> > ---
> > .../bindings/interrupt-controller/interrupts.txt | 29 +++++++--
> > arch/arm/boot/dts/testcases/tests-interrupts.dtsi | 16 +++++
> > arch/arm/boot/dts/versatile-ab.dts | 2 +-
> > arch/arm/boot/dts/versatile-pb.dts | 2 +-
> > drivers/of/irq.c | 16 +++--
> > drivers/of/selftest.c | 70 ++++++++++++++++++++++
> > 6 files changed, 122 insertions(+), 13 deletions(-)
>
> Acked-by: Kumar Gala <galak@codeaurora.org>
>
> [ I think the patch should be split up so we aren't touching versatile dts as part of it ]

No problem, I'll do that.

g.