From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Christoph Lameter <cl@gentwo.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Jeff Liu <jeff.liu@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
benh@kernel.crashing.org, paulus@samba.org,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
herbert@gondor.apana.org.au, davem@davemloft.net,
stefanr@s5r6.in-berlin.de, joro@8bytes.org,
jejb@parisc-linux.org, deller@gmx.de, bhelgaas@google.com,
clm@fb.com, Josef Bacik <jbacik@fb.com>,
swhiteho@redhat.com, bharrosh@panasas.com,
bhalevy@primarydata.com, ccaulfie@redhat.com,
teigland@redhat.com, "Theodore Ts'o" <tytso@mit.edu>,
adilger.kernel@dilger.ca, jaegeuk@kernel.org,
cm224.lee@samsung.com, Mark Fasheh <mfasheh@suse.com>,
Joel Becker <jlbec@evilplan.org>,
casey@schaufler-ca.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 01/24] kobject: return actual error on kset_create_and_add
Date: Tue, 17 Jun 2014 09:54:49 -0700 [thread overview]
Message-ID: <1403024089.1995.0.camel@jarvis> (raw)
In-Reply-To: <alpine.DEB.2.11.1406171128540.20610@gentwo.org>
On Tue, 2014-06-17 at 11:29 -0500, Christoph Lameter wrote:
> On Tue, 17 Jun 2014, James Bottomley wrote:
>
> > What useful information does this supply? The current assumption on
> > NULL return is -ENOMEM ... what's the interesting case where this
> > assumption is wrong?
>
> No idea. Sysfs just ignored all error codes and returns NULL right now.
> If it is indeed just ENOMEN then we have no issue.
Well, I think when we have that justification, then we can decide on the
merits of the patch set.
James
next prev parent reply other threads:[~2014-06-17 16:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 14:25 [PATCH 01/24] kobject: return actual error on kset_create_and_add Jeff Liu
2014-06-17 14:42 ` James Bottomley
2014-06-17 14:56 ` Jeff Liu
2014-06-17 15:50 ` Greg KH
2014-06-17 19:26 ` Greg KH
2014-06-18 1:40 ` Jeff Liu
2014-06-17 15:47 ` Greg KH
2014-06-17 16:00 ` Christoph Lameter
2014-06-17 16:09 ` James Bottomley
2014-06-17 16:29 ` Christoph Lameter
2014-06-17 16:54 ` James Bottomley [this message]
2014-06-17 19:21 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403024089.1995.0.camel@jarvis \
--to=james.bottomley@hansenpartnership.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bhalevy@primarydata.com \
--cc=bharrosh@panasas.com \
--cc=bhelgaas@google.com \
--cc=casey@schaufler-ca.com \
--cc=ccaulfie@redhat.com \
--cc=cl@gentwo.org \
--cc=clm@fb.com \
--cc=cm224.lee@samsung.com \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=jaegeuk@kernel.org \
--cc=jbacik@fb.com \
--cc=jeff.liu@oracle.com \
--cc=jejb@parisc-linux.org \
--cc=jlbec@evilplan.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=mpm@selenic.com \
--cc=paulus@samba.org \
--cc=penberg@kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=stefanr@s5r6.in-berlin.de \
--cc=swhiteho@redhat.com \
--cc=teigland@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox