linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anil Belur <askb23@gmail.com>
To: andreas.dilger@intel.com, oleg.drokin@intel.com,
	gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, hpdd-discuss@ml01.01.org,
	Anil Belur <askb23@gmail.com>
Subject: [PATCH v7 7/8] staging: lustre: lclient: lcommon_cl.c fixing coding style issues
Date: Wed, 18 Jun 2014 18:23:55 +1000	[thread overview]
Message-ID: <1403079836-9304-8-git-send-email-askb23@gmail.com> (raw)
In-Reply-To: <1403079836-9304-1-git-send-email-askb23@gmail.com>

From: Anil Belur <askb23@gmail.com>

fixed: WARNING: line over 80 characters, used a new variable 'size_index' to
store the offset. Replaced "unsigned long" with  "loff_t" type for
'cur_index'. Removed the parenthesis around the second part of the if statement following the '||' as its not required.

Signed-off-by: Anil Belur <askb23@gmail.com>
---
 drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
index 2f51b76..b8552ab 100644
--- a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
+++ b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
@@ -821,10 +821,11 @@ int ccc_prep_size(const struct lu_env *env, struct cl_object *obj,
 				 * linux-2.6.18-128.1.1 miss to do that.
 				 * --bug 17336 */
 				loff_t size = cl_isize_read(inode);
-				unsigned long cur_index = start >> PAGE_CACHE_SHIFT;
+				loff_t cur_index = start >> PAGE_CACHE_SHIFT;
+				loff_t size_index = ((size - 1) >> PAGE_CACHE_SHIFT);
 
 				if ((size == 0 && cur_index != 0) ||
-				    (((size - 1) >> PAGE_CACHE_SHIFT) < cur_index))
+				    size_index < cur_index)
 				*exceed = 1;
 			}
 			return result;
-- 
1.9.0


  parent reply	other threads:[~2014-06-18  8:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-18  8:23 [PATCH v7] staging: lustre: lclient: fixing coding style issues Anil Belur
2014-06-18  8:23 ` [PATCH v7 1/8] staging: lustre: lclient: glimpse.c " Anil Belur
2014-06-18  8:23 ` [PATCH v7 2/8] " Anil Belur
2014-06-18  8:23 ` [PATCH v7 3/8] staging: lustre: lclient: lcommon_misc.c " Anil Belur
2014-06-18  8:23 ` [PATCH v7 4/8] staging: lustre: lclient: lcommon_cl.c " Anil Belur
2014-06-18  8:23 ` [PATCH v7 5/8] " Anil Belur
2014-06-18  8:23 ` [PATCH v7 6/8] " Anil Belur
2014-06-18  8:23 ` Anil Belur [this message]
2014-06-18  8:23 ` [PATCH v7 8/8] " Anil Belur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403079836-9304-8-git-send-email-askb23@gmail.com \
    --to=askb23@gmail.com \
    --cc=andreas.dilger@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpdd-discuss@ml01.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).