From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752778AbaFRNy3 (ORCPT ); Wed, 18 Jun 2014 09:54:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8767 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751093AbaFRNy2 (ORCPT ); Wed, 18 Jun 2014 09:54:28 -0400 Message-ID: <1403099643.32688.30.camel@deneb.redhat.com> Subject: Re: [PATCH] arm64: export __cpu_{clear,copy}_user_page functions From: Mark Salter To: Catalin Marinas Cc: Will Deacon , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Date: Wed, 18 Jun 2014 09:54:03 -0400 In-Reply-To: <20140618103954.GC14680@arm.com> References: <1403025266-2326-1-git-send-email-msalter@redhat.com> <20140618103954.GC14680@arm.com> Organization: Red Hat, Inc Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2014-06-18 at 11:39 +0100, Catalin Marinas wrote: > On Tue, Jun 17, 2014 at 06:14:26PM +0100, Mark Salter wrote: > > The __cpu_clear_user_page() and __cpu_copy_user_page() functions > > are not currently exported. This prevents modules from using > > clear_user_page() and opy_user_page(). > > > > Signed-off-by: Mark Salter > > --- > > arch/arm64/mm/copypage.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm64/mm/copypage.c b/arch/arm64/mm/copypage.c > > index 9aecbac..13bbc3be 100644 > > --- a/arch/arm64/mm/copypage.c > > +++ b/arch/arm64/mm/copypage.c > > @@ -27,8 +27,10 @@ void __cpu_copy_user_page(void *kto, const void *kfrom, unsigned long vaddr) > > copy_page(kto, kfrom); > > __flush_dcache_area(kto, PAGE_SIZE); > > } > > +EXPORT_SYMBOL_GPL(__cpu_copy_user_page); > > > > void __cpu_clear_user_page(void *kaddr, unsigned long vaddr) > > { > > clear_page(kaddr); > > } > > +EXPORT_SYMBOL_GPL(__cpu_clear_user_page); > > I wonder why we still have these functions. I don't think we need any > D-cache flushing for copy_user_page(), so we could simply remove this > code and define copy_user_page() as copy_page() (similarly for > clear_user_page). I'll post a patch separately removing the copy_page, > copy_user_page etc. functions (now that we also have optimised memcpy > and memset). > Even better. I much prefer removing code than adding it. Thanks.