From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752484AbaFRO7q (ORCPT ); Wed, 18 Jun 2014 10:59:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3558 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752411AbaFRO7m (ORCPT ); Wed, 18 Jun 2014 10:59:42 -0400 From: Jiri Olsa To: linux-kernel@vger.kernel.org Cc: Jiri Olsa , Arnaldo Carvalho de Melo , Corey Ashford , David Ahern , Frederic Weisbecker , Ingo Molnar , Jean Pihet , Namhyung Kim , Paul Mackerras , Peter Zijlstra Subject: [PATCH 11/18] perf tools: Use list_move in ordered_event_put function Date: Wed, 18 Jun 2014 16:58:52 +0200 Message-Id: <1403103539-16807-12-git-send-email-jolsa@kernel.org> In-Reply-To: <1403103539-16807-1-git-send-email-jolsa@kernel.org> References: <1403103539-16807-1-git-send-email-jolsa@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As Namhyung pointed out we can use list_move in ordered_event_put. Suggested-by: Namhyung Kim Cc: Arnaldo Carvalho de Melo Cc: Corey Ashford Cc: David Ahern Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Jean Pihet Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Signed-off-by: Jiri Olsa --- tools/perf/util/ordered-events.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/perf/util/ordered-events.c b/tools/perf/util/ordered-events.c index 2e89bea..022be55 100644 --- a/tools/perf/util/ordered-events.c +++ b/tools/perf/util/ordered-events.c @@ -96,8 +96,7 @@ ordered_events_get(struct ordered_events_queue *q, u64 timestamp) void ordered_event_put(struct ordered_events_queue *q, struct ordered_event *iter) { - list_del(&iter->list); - list_add(&iter->list, &q->cache); + list_move(&iter->list, &q->cache); q->nr_events--; } -- 1.8.3.1