From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 06/11] perf ui browser: Fix scrollbar refresh row index
Date: Thu, 19 Jun 2014 18:13:48 -0300 [thread overview]
Message-ID: <1403212433-2714-7-git-send-email-acme@kernel.org> (raw)
In-Reply-To: <1403212433-2714-1-git-send-email-acme@kernel.org>
From: Jiri Olsa <jolsa@kernel.org>
The ui_browser__gotorc function needs offset from 'y' member, so the row
index has to begin with 0, which happens by accident in current code,
because we display only one header line.
The bug shows when we want to display more than 1 header lines like
columns headers in following patches.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1403178076-14072-4-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/ui/browser.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c
index 3ccf6e14f89b..9d2294efc00c 100644
--- a/tools/perf/ui/browser.c
+++ b/tools/perf/ui/browser.c
@@ -279,7 +279,7 @@ static void ui_browser__scrollbar_set(struct ui_browser *browser)
{
int height = browser->height, h = 0, pct = 0,
col = browser->width,
- row = browser->y - 1;
+ row = 0;
if (browser->nr_entries > 1) {
pct = ((browser->index * (browser->height - 1)) /
--
1.9.3
next prev parent reply other threads:[~2014-06-19 21:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 21:13 [GIT PULL 00/11] perf/core improvements and fixes Arnaldo Carvalho de Melo
2014-06-19 21:13 ` [PATCH 01/11] perf trace: Fix up fd -> pathname resolution Arnaldo Carvalho de Melo
2014-06-19 21:13 ` [PATCH 02/11] perf evlist: Add suggestion of how to set perf_event_paranoid sysctl Arnaldo Carvalho de Melo
2014-06-19 21:13 ` [PATCH 03/11] perf trace: Remove needless reassignments Arnaldo Carvalho de Melo
2014-06-19 21:13 ` [PATCH 04/11] perf trace: Cache the is_exit syscall test Arnaldo Carvalho de Melo
2014-06-19 21:13 ` [PATCH 05/11] perf hists browser: Remove ev_name argument from perf_evsel__hists_browse Arnaldo Carvalho de Melo
2014-06-19 21:13 ` Arnaldo Carvalho de Melo [this message]
2014-06-19 21:13 ` [PATCH 07/11] perf bench sched-messaging: Plug memleak Arnaldo Carvalho de Melo
2014-06-19 21:13 ` [PATCH 08/11] perf bench: Add --repeat option Arnaldo Carvalho de Melo
2014-06-19 21:13 ` [PATCH 09/11] perf bench futex: Use global " Arnaldo Carvalho de Melo
2014-06-19 21:13 ` [PATCH 10/11] perf bench mem: The -o and -n options are mutually exclusive Arnaldo Carvalho de Melo
2014-06-19 21:13 ` [PATCH 11/11] perf bench sched-messaging: Drop barf() Arnaldo Carvalho de Melo
2014-06-25 5:43 ` [GIT PULL 00/11] perf/core improvements and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403212433-2714-7-git-send-email-acme@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).