From: Dinh Nguyen <dinguyen@altera.com>
To: Graham Moore <grmoore@altera.com>
Cc: <ggrahammoore@gmail.com>, David Woodhouse <dwmw2@infradead.org>,
"Brian Norris" <computersforpeace@gmail.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
Alan Tull <atull@altera.com>,
"Yves Vandervennet" <rocket.yvanderv@gmail.com>
Subject: Re: [PATCH V2] In the Denali NAND controller driver, use 8 bytes for READID command.
Date: Mon, 23 Jun 2014 14:50:15 -0500 [thread overview]
Message-ID: <1403553015.9081.7.camel@linux-builds1> (raw)
In-Reply-To: <1403551270-31873-1-git-send-email-grmoore@altera.com>
Hi Graham,
On Mon, 2014-06-23 at 14:21 -0500, Graham Moore wrote:
> The Denali NAND driver reads only 5 bytes of ID, but some Hynix and Samsung
> have size parameters in the 6th byte. As a result, the page and oob size
> for a Hynix H27UAG8T2B were calculated incorrectly and the driver failed to
> load.
>
> The solution is to read 8 bytes of ID, as expected by the nand framework.
>
> Signed-off-by: Graham Moore <grmoore@altera.com>
> --
> V2: Increase size of id_bytes array to 8.
> ---
> drivers/mtd/nand/denali.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Your commit header should have "mtd: denali:"
i.e: "mtd: denali: use 8 bytes for READID command"
Dinh
next prev parent reply other threads:[~2014-06-23 19:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 19:21 [PATCH V2] In the Denali NAND controller driver, use 8 bytes for READID command Graham Moore
2014-06-23 19:50 ` Dinh Nguyen [this message]
2014-07-15 1:46 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403553015.9081.7.camel@linux-builds1 \
--to=dinguyen@altera.com \
--cc=atull@altera.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ggrahammoore@gmail.com \
--cc=grmoore@altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rocket.yvanderv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox