From: Raphael Poggi <poggi.raph@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, Raphael Poggi <poggi.raph@gmail.com>
Subject: [PATCH 2/2 RESEND] staging: lirc: remove return void function
Date: Wed, 25 Jun 2014 09:14:31 +0200 [thread overview]
Message-ID: <1403680471-13212-2-git-send-email-poggi.raph@gmail.com> (raw)
In-Reply-To: <1403680471-13212-1-git-send-email-poggi.raph@gmail.com>
This patch fix checkpath "WARNING: void function return statements are not generally useful".
The removed return were useless in that case.
Signed-off-by: Raphaël Poggi <poggi.raph@gmail.com>
---
drivers/staging/media/lirc/lirc_imon.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/staging/media/lirc/lirc_imon.c
index f8c3375..96c76b3 100644
--- a/drivers/staging/media/lirc/lirc_imon.c
+++ b/drivers/staging/media/lirc/lirc_imon.c
@@ -482,8 +482,6 @@ static void usb_tx_callback(struct urb *urb)
/* notify waiters that write has finished */
atomic_set(&context->tx.busy, 0);
complete(&context->tx.finished);
-
- return;
}
/**
@@ -548,7 +546,6 @@ static void ir_close(void *data)
}
mutex_unlock(&context->ctx_lock);
- return;
}
/**
@@ -573,7 +570,6 @@ static void submit_data(struct imon_context *context)
lirc_buffer_write(context->driver->rbuf, buf);
wake_up(&context->driver->rbuf->wait_poll);
- return;
}
static inline int tv2int(const struct timeval *a, const struct timeval *b)
@@ -709,8 +705,6 @@ static void usb_rx_callback(struct urb *urb)
}
usb_submit_urb(context->rx_urb, GFP_ATOMIC);
-
- return;
}
/**
--
1.7.9.5
next prev parent reply other threads:[~2014-06-25 7:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 7:14 [PATCH 1/2 RESEND] staging: lirc: fix checkpath errors: blank lines Raphael Poggi
2014-06-25 7:14 ` Raphael Poggi [this message]
2014-06-26 23:28 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2014-07-01 7:12 Raphael Poggi
2014-07-01 7:12 ` [PATCH 2/2 RESEND] staging: lirc: remove return void function Raphael Poggi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403680471-13212-2-git-send-email-poggi.raph@gmail.com \
--to=poggi.raph@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).