From: Bo Shen <voice.shen@atmel.com>
To: <f.fainelli@gmail.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Bo Shen <voice.shen@atmel.com>
Subject: [RFC PATCH] phy: micrel: make phy_has_fixups attribute read correctly
Date: Wed, 25 Jun 2014 15:24:34 +0800 [thread overview]
Message-ID: <1403681075-16181-1-git-send-email-voice.shen@atmel.com> (raw)
If the fixups parameters get from dtb, it won't set has_fixups
parameters, so when read phy_has_fixups attribute, it always
present as 0.
Add this patch to make phy_has_fixups attribute read correctly.
Signed-off-by: Bo Shen <voice.shen@atmel.com>
---
drivers/net/phy/micrel.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index bc7c7d2..c384922 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -237,6 +237,8 @@ static int ksz9021_load_values_from_of(struct phy_device *phydev,
if (!matches)
return 0;
+ else
+ phydev->has_fixups = true;
if (matches < 4)
newval = kszphy_extended_read(phydev, reg);
@@ -330,6 +332,8 @@ static int ksz9031_of_load_skew_values(struct phy_device *phydev,
if (!matches)
return 0;
+ else
+ phydev->has_fixups = true;
if (matches < numfields)
newval = ksz9031_extended_read(phydev, OP_DATA, 2, reg);
--
1.8.5.2
next reply other threads:[~2014-06-25 7:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 7:24 Bo Shen [this message]
2014-06-26 18:00 ` [RFC PATCH] phy: micrel: make phy_has_fixups attribute read correctly Florian Fainelli
2014-06-27 3:33 ` Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403681075-16181-1-git-send-email-voice.shen@atmel.com \
--to=voice.shen@atmel.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox