From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752790AbdJPMVG (ORCPT ); Mon, 16 Oct 2017 08:21:06 -0400 Received: from mout.web.de ([212.227.17.11]:63331 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750829AbdJPMVD (ORCPT ); Mon, 16 Oct 2017 08:21:03 -0400 Subject: [PATCH 3/3] char/pcmcia: Adjust a null pointer check in three functions From: SF Markus Elfring To: "David S. Miller" , Jarod Wilson , Johannes Berg , Stephen Hemminger , kernel-janitors@vger.kernel.org Cc: LKML References: <5e693086-a995-81ad-4a3f-cf8ab2bac454@users.sourceforge.net> Message-ID: <1403a78d-8fb9-9487-d71d-e51517671153@users.sourceforge.net> Date: Mon, 16 Oct 2017 14:20:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <5e693086-a995-81ad-4a3f-cf8ab2bac454@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:ajCnpOvjuWW1oANrpbusJyNhBftixPLOO7aQTO4iHOimYzd5Bxc CGR8VMwmdo11MFUyjLnqQT72Fcf0UMua6O2csM6vIj92vd0StFXiTLuiOdonHrVPBBSL8Lr w5Qf+9QEScDjjERfZQcj1WIDs3CRjDfVaQqGSZC3pC74M/ILC+YBjYJWJOHsj6QPq7Qpgmq 8Eq0G94KSyS4RTYVLfTPw== X-UI-Out-Filterresults: notjunk:1;V01:K0:GB93HAZeJO0=:1p101KEthE6wQzaxAodJMK R2VMdt/uZo2ztVceYiA9RWFNwPVEtd5J0c0fxMrnnLyZubx0tRVl0PMaR/YcmJhX0k4kmYnvL 71gJ7n0M/3GesA2hCv0mYgk84f4NDRNmg8xTQhmctdKMjTBNSyI4VNS7ED2KAwtsZoZmSg9OD N+wsGr86/TD9a5RLZUTezYyJgmQe5r7xSUrJxolrqyI/fxd9nNBjOdJNe7V9dcJBZutT2N7Wj XAN8nDF2LJFLUsfKo6JD1uyj/92brYaJs81vdTEpPv3gExdy7B5oExmXc4dCfqJMij1/EgJuG 0ydOHy+InAEosQ76pZF+4h38oulnpv2tQFw481dLJhqVGvYEr/hxZIXJzngJ34J0M5gXKduZV KruWA60xlPBb3gaoZ0KidFIA/OKu6gwhNjFfNCo8dQ+RLA0/qYBOWDYfEtN+/Os7OkIEnRJ3Q s/hiVM4hE3u17NQpNDvjzHfJ/XNrKplR/4Sly/W2utFfLp53XahwZbvHEddgzhvFSYHetpQkW DEMFi04lmr9SFL5yERjyVHlmFATT9Zby/QDaMp0QAePAlK8GT/po18o61ALBsjB5BkCLJWu0S 6VIZ2upSp68mKCTaVz8MvpH5DXJQPgXeA7UkRLqxtZ87FKWHvEKiMmqL/bHg1xthn9ioEJ2RZ ZZDhefT73QW+ONeZRlFWbkfgKY/WjrJmyjShHx/S7r+XBJFpj8+D97KfnG8SZ1aERuI5JivHJ 7TdaiEZFbyBVku2nRczVIBS0YxJudaGi/ppiiHFGqy7/sX7jyfxdqDuMrDYpSRsdcz4dUKeyX 0OlO944b9m1T85LXXrsBADkh2dC3qjosBWE8kbjrz1uJA7027w= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 16 Oct 2017 13:46:00 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/char/pcmcia/synclink_cs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c index 6c210b5cdf69..1719d929c0e4 100644 --- a/drivers/char/pcmcia/synclink_cs.c +++ b/drivers/char/pcmcia/synclink_cs.c @@ -2644,7 +2644,7 @@ static int rx_alloc_buffers(MGSLPC_INFO *info) info->rx_buf_count = info->rx_buf_total_size / info->rx_buf_size; info->rx_buf = kmalloc(info->rx_buf_total_size, GFP_KERNEL); - if (info->rx_buf == NULL) + if (!info->rx_buf) return -ENOMEM; /* unused flag buffer to satisfy receive_buf calling interface */ @@ -4228,7 +4228,7 @@ static void hdlcdev_rx(MGSLPC_INFO *info, char *buf, int size) if (debug_level >= DEBUG_LEVEL_INFO) printk("hdlcdev_rx(%s)\n", dev->name); - if (skb == NULL) { + if (!skb) { printk(KERN_NOTICE "%s: can't alloc skb, dropping packet\n", dev->name); dev->stats.rx_dropped++; return; @@ -4269,7 +4269,7 @@ static int hdlcdev_init(MGSLPC_INFO *info) /* allocate and initialize network and HDLC layer objects */ dev = alloc_hdlcdev(info); - if (dev == NULL) { + if (!dev) { printk(KERN_ERR "%s:hdlc device allocation failure\n", __FILE__); return -ENOMEM; } -- 2.14.2