From: Nicholas Krause <xerofoify@gmail.com>
To: ulli.kroll@googlemail.com
Cc: linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] Fixes gemmi_idle in file idle.c
Date: Sun, 29 Jun 2014 22:52:40 -0400 [thread overview]
Message-ID: <1404096760-5239-1-git-send-email-xerofoify@gmail.com> (raw)
disables the IRQ line in gemmi_idle before calling cpu_do_idle.
In addition, according to the Fixme message in this file fixes
races that may occur due to not disabling the IRQ before calling
cpu_do_idle.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
arch/arm/mach-gemini/idle.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/mach-gemini/idle.c b/arch/arm/mach-gemini/idle.c
index ddf8ec9..2880f5a 100644
--- a/arch/arm/mach-gemini/idle.c
+++ b/arch/arm/mach-gemini/idle.c
@@ -17,8 +17,7 @@ static void gemini_idle(void)
* disabled.
*/
- /* FIXME: Enabling interrupts here is racy! */
- local_irq_enable();
+ local_irq_disable();
cpu_do_idle();
}
--
1.9.1
next reply other threads:[~2014-06-30 2:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 2:52 Nicholas Krause [this message]
2014-06-30 6:43 ` [PATCH] Fixes gemmi_idle in file idle.c Arnd Bergmann
2014-06-30 9:41 ` Russell King - ARM Linux
2014-07-01 1:59 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404096760-5239-1-git-send-email-xerofoify@gmail.com \
--to=xerofoify@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox