linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Corey Ashford <cjashfor@linux.vnet.ibm.com>,
	David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 3/3] perf tools: Add ui.show-headers config file option
Date: Mon, 30 Jun 2014 20:13:24 +0900	[thread overview]
Message-ID: <1404126804.1648.12.camel@leonhard> (raw)
In-Reply-To: <1403886418-5556-4-git-send-email-jolsa@kernel.org>

Hi Jiri,

2014-06-27 (금), 18:26 +0200, Jiri Olsa:
> Adding report.show-headers config file option to setup
> the appearance of the columns headers.
> 
> Currently columns headers are displayed by default, following
> lines in ~/.perfconfig file will disable that:
> 
>   [ui]
>         show-headers = true

s/true/false/  :)

I'm afraid that we might need to add some code to show/hide column
headers for stdio and GTK too..


> 
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>

Anyway, with above typo fixed, patches look good!

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung



  reply	other threads:[~2014-06-30 11:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-27 16:26 [PATCHv4 0/3] perf tools tui: Display columns headers Jiri Olsa
2014-06-27 16:26 ` [PATCH 1/3] perf tools tui: Remove width setting from hist_browser__refresh_dimensions Jiri Olsa
2014-06-27 16:26 ` [PATCH 2/3] perf tools tui: Display columns header text on 'H' press Jiri Olsa
2014-06-27 16:26 ` [PATCH 3/3] perf tools: Add ui.show-headers config file option Jiri Olsa
2014-06-30 11:13   ` Namhyung Kim [this message]
2014-06-30 18:07     ` Jiri Olsa
2014-07-16 19:15   ` [tip:perf/core] perf hists browser: " tip-bot for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404126804.1648.12.camel@leonhard \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=cjashfor@linux.vnet.ibm.com \
    --cc=dsahern@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).