From: navin patidar <navin.patidar@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
navin patidar <navin.patidar@gmail.com>
Subject: [PATCH 37/48] staging: rtl8188eu: Remove members cmd_[allocated,]_buf from struct cmd_priv
Date: Wed, 2 Jul 2014 22:17:33 +0530 [thread overview]
Message-ID: <1404319664-8327-37-git-send-email-navin.patidar@gmail.com> (raw)
In-Reply-To: <1404319664-8327-1-git-send-email-navin.patidar@gmail.com>
Signed-off-by: navin patidar <navin.patidar@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 32 ++-------------------------
drivers/staging/rtl8188eu/include/rtw_cmd.h | 2 --
2 files changed, 2 insertions(+), 32 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c
index 199bbae..817f459 100644
--- a/drivers/staging/rtl8188eu/core/rtw_cmd.c
+++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c
@@ -32,39 +32,18 @@ No irqsave is necessary.
int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv)
{
- int res = _SUCCESS;
-
-
sema_init(&(pcmdpriv->cmd_queue_sema), 0);
- /* sema_init(&(pcmdpriv->cmd_done_sema), 0); */
sema_init(&(pcmdpriv->terminate_cmdthread_sema), 0);
-
_rtw_init_queue(&(pcmdpriv->cmd_queue));
- /* allocate DMA-able/Non-Page memory for cmd_buf and rsp_buf */
-
pcmdpriv->cmd_seq = 1;
-
- pcmdpriv->cmd_allocated_buf = kzalloc(MAX_CMDSZ + CMDBUFF_ALIGN_SZ, GFP_KERNEL);
-
- if (pcmdpriv->cmd_allocated_buf == NULL) {
- res = _FAIL;
- goto exit;
- }
-
- pcmdpriv->cmd_buf = pcmdpriv->cmd_allocated_buf + CMDBUFF_ALIGN_SZ - ((size_t)(pcmdpriv->cmd_allocated_buf) & (CMDBUFF_ALIGN_SZ-1));
-
-exit:
- return res;
+ return _SUCCESS;
}
void rtw_free_cmd_priv(struct cmd_priv *pcmdpriv)
{
- if (pcmdpriv) {
- kfree(pcmdpriv->cmd_allocated_buf);
- }
}
/*
@@ -192,7 +171,6 @@ int rtw_cmd_thread(void *context)
{
u8 ret;
struct cmd_obj *pcmd;
- u8 *pcmdbuf;
u8 (*cmd_hdl)(struct adapter *padapter, u8 *pbuf);
void (*pcmd_callback)(struct adapter *dev, struct cmd_obj *pcmd);
struct adapter *padapter = (struct adapter *)context;
@@ -200,8 +178,6 @@ int rtw_cmd_thread(void *context)
allow_signal(SIGTERM);
- pcmdbuf = pcmdpriv->cmd_buf;
-
pcmdpriv->cmdthd_running = true;
up(&pcmdpriv->terminate_cmdthread_sema);
@@ -234,15 +210,11 @@ _next:
goto post_process;
}
- pcmd->cmdsz = round_up(pcmd->cmdsz, 4);
-
- memcpy(pcmdbuf, pcmd->parmbuf, pcmd->cmdsz);
-
if (pcmd->cmdcode < ARRAY_SIZE(wlancmds)) {
cmd_hdl = wlancmds[pcmd->cmdcode].h2cfuns;
if (cmd_hdl) {
- ret = cmd_hdl(pcmd->padapter, pcmdbuf);
+ ret = cmd_hdl(pcmd->padapter, pcmd->parmbuf);
pcmd->res = ret;
}
diff --git a/drivers/staging/rtl8188eu/include/rtw_cmd.h b/drivers/staging/rtl8188eu/include/rtw_cmd.h
index d881710..08b371d 100644
--- a/drivers/staging/rtl8188eu/include/rtw_cmd.h
+++ b/drivers/staging/rtl8188eu/include/rtw_cmd.h
@@ -48,8 +48,6 @@ struct cmd_priv {
struct semaphore terminate_cmdthread_sema;
struct __queue cmd_queue;
u8 cmd_seq;
- u8 *cmd_buf; /* shall be non-paged, and 4 bytes aligned */
- u8 *cmd_allocated_buf;
u8 cmdthd_running;
struct adapter *padapter;
};
--
1.7.10.4
next prev parent reply other threads:[~2014-07-02 16:54 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 16:46 [PATCH 01/48] staging: rtl8188eu: Remove struct evt_priv and its uses navin patidar
2014-07-02 16:46 ` [PATCH 02/48] staging: rtl8188eu: Remove function c2h_evt_hdl() navin patidar
2014-07-02 16:46 ` [PATCH 03/48] staging: rtl8188eu: Remove unused function c2h_evt_read() navin patidar
2014-07-02 16:47 ` [PATCH 04/48] staging: rtl8188eu: Remove unused function c2h_evt_clear() navin patidar
2014-07-02 16:47 ` [PATCH 05/48] staging: rtl8188eu: Remove dummy function rtw_hal_c2h_handler() navin patidar
2014-07-02 16:47 ` [PATCH 06/48] staging: rtl8188eu: Remove unused function rtw_hal_c2h_id_filter_ccx() navin patidar
2014-07-02 16:47 ` [PATCH 07/48] staging: rtl8188eu: rtw_cmd.h: Remove unused macro and structure navin patidar
2014-07-02 16:47 ` [PATCH 08/48] staging: rtl8188eu: Remove unused function rtw_getrttbl_cmd() navin patidar
2014-07-02 16:47 ` [PATCH 09/48] staging: rtl8188eu: Remove unused function rtw_c2h_wk_cmd() navin patidar
2014-07-02 16:47 ` [PATCH 10/48] staging: rtl8188eu: Remove unused function rtw_setbasicrate_cmd() navin patidar
2014-07-02 16:47 ` [PATCH 11/48] staging: rtl8188eu: Remove unused function rtw_setphy_cmd() navin patidar
2014-07-02 16:47 ` [PATCH 12/48] staging: rtl8188eu: Remove unused function rtw_setbbreg_cmd() navin patidar
2014-07-02 16:47 ` [PATCH 13/48] staging: rtl8188eu: Remove unused function rtw_getbbreg_cmd() navin patidar
2014-07-02 16:47 ` [PATCH 14/48] staging: rtl8188eu: Remove unused function rtw_[set,get]rfreg_cmd() navin patidar
2014-07-02 16:47 ` [PATCH 15/48] staging: rtl8188eu: Remove unused function rtw_setrttbl_cmd() navin patidar
2014-07-02 16:47 ` [PATCH 16/48] staging: rtl8188eu: Remove unused function rtw_set_ch_cmd() navin patidar
2014-07-02 16:47 ` [PATCH 17/48] staging: rtl8188eu: Remove unused function rtw_set_csa_cmd() navin patidar
2014-07-02 16:47 ` [PATCH 18/48] staging: rtl8188eu: Remove dummy function rtw_tdls_cmd() navin patidar
2014-07-02 16:47 ` [PATCH 19/48] staging: rtl8188eu: Remove unused function rtw_setassocsta_cmd() navin patidar
2014-07-02 16:47 ` [PATCH 20/48] staging: rtl8188eu: Remove unused function rtw_setstandby_cmd() navin patidar
2014-07-02 16:47 ` [PATCH 21/48] staging: rtl8188eu: Remove unused function rtw_createbss_cmd_ex() navin patidar
2014-07-02 16:47 ` [PATCH 22/48] staging: rtl8188eu: rtw_cmd.h: Remove unused function declaration navin patidar
2014-07-02 16:47 ` [PATCH 23/48] staging: rtl8188eu: rtw_cmd.h: Remove unused macros navin patidar
2014-07-02 16:47 ` [PATCH 24/48] staging: rtl8188eu: rtw_cmd.h: Remove unused structures navin patidar
2014-07-02 16:47 ` [PATCH 25/48] staging: rtl8188eu: Remove unused function rtw_cmd_clr_isr() navin patidar
2014-07-02 16:47 ` [PATCH 26/48] staging: rtl8188eu: rtw_cmd.h: Remove struct [join,create]bss_parm navin patidar
2014-07-02 16:47 ` [PATCH 27/48] staging: rtl8188eu: rtw_cmd.h: Remove struct Tx_Beacon_param navin patidar
2014-07-02 16:47 ` [PATCH 28/48] staging: rtl8188eu: Remove header file cmd_osdep.h navin patidar
2014-07-02 16:47 ` [PATCH 29/48] staging: rtl8188eu: Remove wrapper function power_saving_wk_hdl() navin patidar
2014-07-02 16:47 ` [PATCH 30/48] staging: rtl8188eu: Rename _rtw_init_cmd_priv() to rtw_init_cmd_priv() navin patidar
2014-07-02 16:47 ` [PATCH 31/48] staging: rtl8188eu: Rename _rtw_free_cmd_priv() to rtw_free_cmd_priv() navin patidar
2014-07-02 16:47 ` [PATCH 32/48] staging: rtl8188eu: Rename _rtw_dequeue_cmd() to rtw_dequeue_cmd() navin patidar
2014-07-02 16:47 ` [PATCH 33/48] staging: rtl8188eu: Remove unused member rsp_cnt from struct cmd_priv navin patidar
2014-07-02 16:47 ` [PATCH 34/48] staging: rtl8188eu: Remove unused member cmd_issued_cnt " navin patidar
2014-07-02 16:47 ` [PATCH 35/48] staging: rtl8188eu: Remove unused member cmd_done_cnt " navin patidar
2014-07-02 16:47 ` [PATCH 36/48] staging: rtl8188eu: Remove unused members rsp_[allocated,]_buf " navin patidar
2014-07-02 16:47 ` navin patidar [this message]
2014-07-02 16:47 ` [PATCH 38/48] staging: rtl8188eu: Remove function rtw_getbbrfreg_cmdrsp_callback() navin patidar
2014-07-02 16:47 ` [PATCH 39/48] staging: rtl8188eu: Remove function rtw_setdatarate_cmd() navin patidar
2014-07-02 16:47 ` [PATCH 40/48] staging: rtl8188eu: rtw_[cmd, mlme_ext].h: Remove unused command codes navin patidar
2014-07-02 16:47 ` [PATCH 41/48] staging: rtl8188eu: rtw_cmd.h: Remove unused structures navin patidar
2014-07-02 16:47 ` [PATCH 42/48] staging: rtl8188eu: Remove command _TDLS and its handler navin patidar
2014-07-02 16:47 ` [PATCH 43/48] staging: rtl8188eu: Remove command _SetChannelSwitch " navin patidar
2014-07-02 16:47 ` [PATCH 44/48] staging: rtl8188eu: Remove command _LedBlink " navin patidar
2014-07-02 16:47 ` [PATCH 45/48] staging: rtl8188eu: Remove command _Set_H2C_MSG " navin patidar
2014-07-02 16:47 ` [PATCH 46/48] staging: rtl8188eu: rtw_cmd.h: Remove unused structures navin patidar
2014-07-02 16:47 ` [PATCH 47/48] staging: rtl8188eu: Remove cmd_seq from struct cmd_priv navin patidar
2014-07-02 16:47 ` [PATCH 48/48] staging: rtl8188eu: Remove dummy function rtw_free_cmd_priv() navin patidar
2014-07-09 19:05 ` [PATCH 01/48] staging: rtl8188eu: Remove struct evt_priv and its uses Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404319664-8327-37-git-send-email-navin.patidar@gmail.com \
--to=navin.patidar@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox