From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753712AbaGCSgj (ORCPT ); Thu, 3 Jul 2014 14:36:39 -0400 Received: from cpsmtpb-ews04.kpnxchange.com ([213.75.39.7]:56497 "EHLO cpsmtpb-ews04.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726AbaGCSgi (ORCPT ); Thu, 3 Jul 2014 14:36:38 -0400 Message-ID: <1404412596.16291.30.camel@x220> Subject: Re: [PATCH 2/2] mach-spear: fixed spear1340.c file From: Paul Bolle To: Nick Krause Cc: Viresh Kumar , Shiraz Hashim , Russell King - ARM Linux , spear-devel@list.st.com, linux-arm-kernel@lists.infradead.org, "linux-kernel@vger.kernel.org" Date: Thu, 03 Jul 2014 20:36:36 +0200 In-Reply-To: References: <1404354994-7478-1-git-send-email-xerofoify@gmail.com> <1404410691.16291.11.camel@x220> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-2.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 03 Jul 2014 18:36:36.0911 (UTC) FILETIME=[B8D053F0:01CF96ED] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [I fixed the top posting.] On Thu, 2014-07-03 at 14:08 -0400, Nick Krause wrote: > On Thu, Jul 3, 2014 at 2:04 PM, Paul Bolle wrote: > > This patch, together with patch 1/2, basically moves a chunk of code > > into a separate file, didn't it? If so, why did you split that move in > > two patches? > > Yes it is and I did it in two patches in order to be more readable. It makes it harder to understand the change (I had to _guess_ it was a move). Moreover, depending on the order that these two patches would be merged, we could end up with a chunk of code being either included twice or not included at all, in some range of commits. Neither would be good. > > And how does all this work without any changes to a Makefile? > > Furthermore I don't known Kconfig well enough to do the Makefile > for the file I created. Then I think you should, well, study the kernel build system before submitting a change like this. And you can also ask a question or two to get things going. (Not sure what the relevant list would be.) Paul Bolle