From: Bernd Petrovitsch <bernd@petrovitsch.priv.at>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "xiaofeng.yan" <xiaofeng.yan@huawei.com>,
mingo@redhat.com, juri.lelli@gmail.com,
linux-kernel@vger.kernel.org, xiaofeng.yan2012@gmail.com
Subject: Re: [PATCH] sched/deadline: overrun could happen in start_hrtick_dl
Date: Tue, 08 Jul 2014 11:49:49 +0200 [thread overview]
Message-ID: <1404812992.29824.2.camel@thorin> (raw)
In-Reply-To: <20140708093334.GD6758@twins.programming.kicks-ass.net>
On Die, 2014-07-08 at 11:33 +0200, Peter Zijlstra wrote:
[...]
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index fc4f98b1258f..e1e24eea8061 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -999,8 +999,7 @@ static void start_hrtick_dl(struct rq *rq, struct task_struct *p)
> {
> s64 delta = p->dl.dl_runtime - p->dl.runtime;
This line can be removed as well (an then we have a one-line
function ....).
> - if (delta > 10000)
> - hrtick_start(rq, p->dl.runtime);
> + hrtick_start(rq, p->dl.runtime);
> }
> #endif
Bernd
--
"I dislike type abstraction if it has no real reason. And saving
on typing is not a good reason - if your typing speed is the main
issue when you're coding, you're doing something seriously wrong."
- Linus Torvalds
next prev parent reply other threads:[~2014-07-08 10:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 8:53 [PATCH] sched/deadline: overrun could happen in start_hrtick_dl xiaofeng.yan
2014-07-08 9:23 ` xiaofeng.yan
2014-07-08 9:33 ` Peter Zijlstra
2014-07-08 9:49 ` Bernd Petrovitsch [this message]
2014-07-08 11:23 ` xiaofeng.yan
2014-07-08 11:50 ` xiaofeng.yan
2014-07-08 12:52 ` Peter Zijlstra
2014-07-09 2:07 ` xiaofeng.yan
-- strict thread matches above, loose matches on Subject: below --
2014-07-08 9:06 xiaofeng.yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404812992.29824.2.camel@thorin \
--to=bernd@petrovitsch.priv.at \
--cc=juri.lelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=xiaofeng.yan2012@gmail.com \
--cc=xiaofeng.yan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox