Re: [dm-devel] [PATCH] blk-lib: fix error reporting

Christoph Hellwig
2014-07-08T09:50:41Z

> + if (unlikely(err))
> + ACCESS_ONCE(bb->error) = err;

I can't see a reason for the ACCESS_ONCE here.

Also the likely/unlikely annotations here smell like premature
optimization.

Otherwise looks good to me.