From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Fabio Falzoi <fabio.falzoi84@gmail.com>,
micky <micky_ching@realsil.com.cn>,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
wei_wang@realsil.com.cn, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes
Date: Tue, 08 Jul 2014 09:33:31 -0700 [thread overview]
Message-ID: <1404837211.932.18.camel@joe-AO725> (raw)
In-Reply-To: <20140708084517.GG25880@mwanda>
On Tue, 2014-07-08 at 11:45 +0300, Dan Carpenter wrote:
> On Tue, Jul 08, 2014 at 08:23:02AM +0200, Fabio Falzoi wrote:
> I'm gonna fix it, thanks.
> And leave out the semi-colon as well.
another way to do this is:
static void rtsx_hex_dump(void *buf, size_t len)
{
#if DEBUG
print_hex_dump_bytes(KBUILD_MODNAME ": ", DUMP_PREFIX_NONE, buf, len);
#endif
}
next prev parent reply other threads:[~2014-07-08 16:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 7:10 [PATCH v2 0/4] Staging: rts5208: Use standard debug features Fabio Falzoi
2014-07-07 7:10 ` [PATCH v2 1/4] Staging: rts5208: Replace custom macro with pr_debug Fabio Falzoi
2014-07-07 7:10 ` [PATCH v2 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes Fabio Falzoi
2014-07-08 2:12 ` micky
2014-07-08 6:23 ` Fabio Falzoi
2014-07-08 8:45 ` Dan Carpenter
2014-07-08 16:33 ` Joe Perches [this message]
2014-07-07 7:10 ` [PATCH v2 3/4] Staging: rts5208: Remove CONFIG_RTS5208_DEBUG option Fabio Falzoi
2014-07-07 7:10 ` [PATCH v2 4/4] Staging: rts5208: Fix a format specifier for dev_err Fabio Falzoi
2014-07-08 2:13 ` micky
2014-07-08 6:22 ` Fabio Falzoi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404837211.932.18.camel@joe-AO725 \
--to=joe@perches.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.falzoi84@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=micky_ching@realsil.com.cn \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox