From: konrad@kernel.org
To: xen-devel@lists.xenproject.org, david.vrabel@citrix.com,
boris.ostrovsky@oracle.com, linux-kernel@vger.kernel.org
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [PATCH v3 5/7] xen/pciback: Include the domain id if removing the device whilst still in use
Date: Tue, 8 Jul 2014 14:58:27 -0400 [thread overview]
Message-ID: <1404845909-13563-6-git-send-email-konrad@kernel.org> (raw)
In-Reply-To: <1404845909-13563-1-git-send-email-konrad@kernel.org>
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cleanup the function a bit - also include the id of the
domain that is using the device.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
drivers/xen/xen-pciback/pci_stub.c | 10 ++++++----
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen-pciback/pci_stub.c
index 6bb6be8..df485ec 100644
--- a/drivers/xen/xen-pciback/pci_stub.c
+++ b/drivers/xen/xen-pciback/pci_stub.c
@@ -615,12 +615,14 @@ static void pcistub_remove(struct pci_dev *dev)
spin_unlock_irqrestore(&pcistub_devices_lock, flags);
if (found_psdev) {
- dev_dbg(&dev->dev, "found device to remove - in use? %p\n",
- found_psdev->pdev);
+ dev_dbg(&dev->dev, "found device to remove %s\n",
+ found_psdev->pdev ? "- in-use" : "");
if (found_psdev->pdev) {
- pr_warn("****** removing device %s while still in-use! ******\n",
- pci_name(found_psdev->dev));
+ int domid = xen_find_device_domain_owner(dev);
+
+ pr_warn("****** removing device %s while still in-use by domain %d! ******\n",
+ pci_name(found_psdev->dev), domid);
pr_warn("****** driver domain may still access this device's i/o resources!\n");
pr_warn("****** shutdown driver domain before binding device\n");
pr_warn("****** to other drivers or domains\n");
--
1.7.7.6
next prev parent reply other threads:[~2014-07-08 17:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 18:58 [PATCH] Xen PCIbackend support for slot and bus reset (v3) konrad
2014-07-08 18:58 ` [PATCH v3 1/7] xen-pciback: Document the various parameters and attributes in SysFS konrad
2014-07-08 18:18 ` [Xen-devel] " Andrew Cooper
2014-07-09 12:17 ` David Vrabel
2014-07-09 13:59 ` Konrad Rzeszutek Wilk
2014-07-09 14:05 ` Andrew Cooper
2014-07-09 14:13 ` Konrad Rzeszutek Wilk
2014-07-09 14:22 ` Andrew Cooper
2014-07-09 14:25 ` Konrad Rzeszutek Wilk
2014-07-09 14:45 ` David Vrabel
2014-07-09 14:47 ` Konrad Rzeszutek Wilk
2014-07-09 14:57 ` David Vrabel
2014-07-09 15:11 ` Konrad Rzeszutek Wilk
2014-07-08 18:58 ` [PATCH v3 2/7] xen/pciback: Don't deadlock when unbinding konrad
2014-07-09 12:21 ` David Vrabel
2014-07-09 14:01 ` Konrad Rzeszutek Wilk
2014-07-08 18:58 ` [PATCH v3 3/7] xen/pciback: Move the FLR code to a function konrad
2014-07-08 18:58 ` [PATCH v3 4/7] xen/pciback: Implement PCI reset slot or bus with 'do_flr' SysFS attribute konrad
2014-07-08 18:02 ` David Vrabel
2014-07-08 18:46 ` Konrad Rzeszutek Wilk
2014-07-08 19:28 ` Konrad Rzeszutek Wilk
2014-07-09 12:32 ` David Vrabel
2014-07-09 14:11 ` [Xen-devel] " David Vrabel
2014-07-09 14:12 ` Konrad Rzeszutek Wilk
2014-07-09 14:26 ` David Vrabel
2014-07-09 15:07 ` Konrad Rzeszutek Wilk
2014-07-08 18:17 ` [Xen-devel] " Andrew Cooper
2014-07-08 18:58 ` konrad [this message]
2014-07-09 12:34 ` [PATCH v3 5/7] xen/pciback: Include the domain id if removing the device whilst still in use David Vrabel
2014-07-08 18:58 ` [PATCH v3 6/7] xen/pciback: Print out the domain owning the device konrad
2014-07-09 13:04 ` David Vrabel
2014-07-08 18:58 ` [PATCH v3 7/7] xen/pciback: Remove tons of dereferences konrad
2014-07-08 19:15 ` [Xen-devel] [PATCH] Xen PCIbackend support for slot and bus reset (v3) Sander Eikelenboom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404845909-13563-6-git-send-email-konrad@kernel.org \
--to=konrad@kernel.org \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox