From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
Namhyung Kim <namhyung@kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>
Subject: [PATCH 1/6] perf tools: Left-align output contents
Date: Wed, 9 Jul 2014 14:28:09 +0900 [thread overview]
Message-ID: <1404883694-5342-2-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1404883694-5342-1-git-send-email-namhyung@kernel.org>
Now perf left-aligns column headers but the contents does not. It
should have same alignment.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/sort.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index 14e5a039bc45..9a531743c8c2 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -70,7 +70,7 @@ static int hist_entry__thread_snprintf(struct hist_entry *he, char *bf,
size_t size, unsigned int width)
{
const char *comm = thread__comm_str(he->thread);
- return repsep_snprintf(bf, size, "%*s:%5d", width - 6,
+ return repsep_snprintf(bf, size, "%-*s:%5d", width - 6,
comm ?: "", he->thread->tid);
}
@@ -106,7 +106,7 @@ sort__comm_sort(struct hist_entry *left, struct hist_entry *right)
static int hist_entry__comm_snprintf(struct hist_entry *he, char *bf,
size_t size, unsigned int width)
{
- return repsep_snprintf(bf, size, "%*s", width, comm__str(he->comm));
+ return repsep_snprintf(bf, size, "%-*s", width, comm__str(he->comm));
}
struct sort_entry sort_comm = {
@@ -305,7 +305,7 @@ static int hist_entry__srcline_snprintf(struct hist_entry *he, char *bf,
size_t size,
unsigned int width __maybe_unused)
{
- return repsep_snprintf(bf, size, "%s", he->srcline);
+ return repsep_snprintf(bf, size, "%-s", he->srcline);
}
struct sort_entry sort_srcline = {
--
2.0.0
next prev parent reply other threads:[~2014-07-09 5:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 5:28 [PATCHSET 0/6] perf tools: Honor column width setting Namhyung Kim
2014-07-09 5:28 ` Namhyung Kim [this message]
2014-07-09 5:28 ` [PATCH 2/6] perf tools: Make __hpp__fmt() receive an additional len argument Namhyung Kim
2014-07-09 5:28 ` [PATCH 3/6] perf tools: Save column length in perf_hpp_fmt Namhyung Kim
2014-07-24 12:10 ` Jiri Olsa
2014-07-24 15:46 ` Namhyung Kim
2014-07-24 15:58 ` Jiri Olsa
2014-07-09 5:28 ` [PATCH 4/6] perf report: Honor column width setting Namhyung Kim
2014-07-24 12:47 ` Jiri Olsa
2014-07-24 15:51 ` Namhyung Kim
2014-07-24 12:57 ` Jiri Olsa
2014-07-24 13:57 ` Arnaldo Carvalho de Melo
2014-07-24 14:49 ` Jiri Olsa
2014-07-24 15:41 ` Namhyung Kim
2014-07-24 15:58 ` Jiri Olsa
2014-07-24 19:14 ` Arnaldo Carvalho de Melo
2014-07-09 5:28 ` [PATCH 5/6] perf top: Add -w option for setting column width Namhyung Kim
2014-07-09 5:28 ` [PATCH 6/6] perf tools: Add name field into perf_hpp_fmt Namhyung Kim
2014-07-21 9:07 ` [PATCHSET 0/6] perf tools: Honor column width setting Jiri Olsa
2014-07-23 7:40 ` Namhyung Kim
2014-07-24 13:11 ` Jiri Olsa
2014-07-24 13:59 ` Arnaldo Carvalho de Melo
2014-07-24 15:42 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404883694-5342-2-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox