linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiang Liu <jiang.liu@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Mel Gorman <mgorman@suse.de>,
	David Rientjes <rientjes@google.com>,
	Mike Galbraith <umgwanakikbuti@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
	Tejun Heo <tj@kernel.org>,
	Christoph Lameter <cl@linux-foundation.org>,
	Vladimir Davydov <vdavydov@parallels.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Jiang Liu <jiang.liu@linux.intel.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Rik van Riel <riel@redhat.com>,
	Wanpeng Li <liwanp@linux.vnet.ibm.com>,
	Zhang Yanfei <zhangyanfei@cn.fujitsu.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Jianyu Zhan <nasa4836@gmail.com>, malc <av1474@comtv.ru>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Fabian Frederick <fabf@skynet.be>
Cc: Tony Luck <tony.luck@intel.com>,
	linux-mm@kvack.org, linux-hotplug@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [RFC Patch V1 07/30] mm: Use cpu_to_mem()/numa_mem_id() to support memoryless node
Date: Fri, 11 Jul 2014 15:37:24 +0800	[thread overview]
Message-ID: <1405064267-11678-8-git-send-email-jiang.liu@linux.intel.com> (raw)
In-Reply-To: <1405064267-11678-1-git-send-email-jiang.liu@linux.intel.com>

When CONFIG_HAVE_MEMORYLESS_NODES is enabled, cpu_to_node()/numa_node_id()
may return a node without memory, and later cause system failure/panic
when calling kmalloc_node() and friends with returned node id.
So use cpu_to_mem()/numa_mem_id() instead to get the nearest node with
memory for the/current cpu.

If CONFIG_HAVE_MEMORYLESS_NODES is disabled, cpu_to_mem()/numa_mem_id()
is the same as cpu_to_node()/numa_node_id().

Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
---
 include/linux/gfp.h |    6 +++---
 mm/memory.c         |    2 +-
 mm/percpu-vm.c      |    2 +-
 mm/vmalloc.c        |    2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/include/linux/gfp.h b/include/linux/gfp.h
index 6eb1fb37de9a..56dd2043f510 100644
--- a/include/linux/gfp.h
+++ b/include/linux/gfp.h
@@ -314,7 +314,7 @@ static inline struct page *alloc_pages_node(int nid, gfp_t gfp_mask,
 {
 	/* Unknown node is current node */
 	if (nid < 0)
-		nid = numa_node_id();
+		nid = numa_mem_id();
 
 	return __alloc_pages(gfp_mask, order, node_zonelist(nid, gfp_mask));
 }
@@ -340,13 +340,13 @@ extern struct page *alloc_pages_vma(gfp_t gfp_mask, int order,
 			int node);
 #else
 #define alloc_pages(gfp_mask, order) \
-		alloc_pages_node(numa_node_id(), gfp_mask, order)
+		alloc_pages_node(numa_mem_id(), gfp_mask, order)
 #define alloc_pages_vma(gfp_mask, order, vma, addr, node)	\
 	alloc_pages(gfp_mask, order)
 #endif
 #define alloc_page(gfp_mask) alloc_pages(gfp_mask, 0)
 #define alloc_page_vma(gfp_mask, vma, addr)			\
-	alloc_pages_vma(gfp_mask, 0, vma, addr, numa_node_id())
+	alloc_pages_vma(gfp_mask, 0, vma, addr, numa_mem_id())
 #define alloc_page_vma_node(gfp_mask, vma, addr, node)		\
 	alloc_pages_vma(gfp_mask, 0, vma, addr, node)
 
diff --git a/mm/memory.c b/mm/memory.c
index d67fd9fcf1f2..f434d2692f70 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -3074,7 +3074,7 @@ static int numa_migrate_prep(struct page *page, struct vm_area_struct *vma,
 	get_page(page);
 
 	count_vm_numa_event(NUMA_HINT_FAULTS);
-	if (page_nid == numa_node_id()) {
+	if (page_nid == numa_mem_id()) {
 		count_vm_numa_event(NUMA_HINT_FAULTS_LOCAL);
 		*flags |= TNF_FAULT_LOCAL;
 	}
diff --git a/mm/percpu-vm.c b/mm/percpu-vm.c
index 3707c71ae4cd..a20b8f7d0dd0 100644
--- a/mm/percpu-vm.c
+++ b/mm/percpu-vm.c
@@ -115,7 +115,7 @@ static int pcpu_alloc_pages(struct pcpu_chunk *chunk,
 		for (i = page_start; i < page_end; i++) {
 			struct page **pagep = &pages[pcpu_page_idx(cpu, i)];
 
-			*pagep = alloc_pages_node(cpu_to_node(cpu), gfp, 0);
+			*pagep = alloc_pages_node(cpu_to_mem(cpu), gfp, 0);
 			if (!*pagep) {
 				pcpu_free_pages(chunk, pages, populated,
 						page_start, page_end);
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index f64632b67196..c06f90641916 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -800,7 +800,7 @@ static struct vmap_block *new_vmap_block(gfp_t gfp_mask)
 	unsigned long vb_idx;
 	int node, err;
 
-	node = numa_node_id();
+	node = numa_mem_id();
 
 	vb = kmalloc_node(sizeof(struct vmap_block),
 			gfp_mask & GFP_RECLAIM_MASK, node);
-- 
1.7.10.4


  parent reply	other threads:[~2014-07-11  7:35 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11  7:37 [RFC Patch V1 00/30] Enable memoryless node on x86 platforms Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 01/30] mm, kernel: Use cpu_to_mem()/numa_mem_id() to support memoryless node Jiang Liu
2014-07-11 15:14   ` Paul E. McKenney
2014-07-21 17:15     ` Nishanth Aravamudan
2014-07-21 17:33       ` Paul E. McKenney
2014-07-12 12:32   ` Jens Axboe
2014-07-11  7:37 ` [RFC Patch V1 02/30] mm, sched: " Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 03/30] mm, net: " Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 04/30] mm, netfilter: " Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 05/30] mm, perf: " Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 06/30] mm, tracing: " Jiang Liu
2014-07-11  7:37 ` Jiang Liu [this message]
2014-07-11 13:51   ` [RFC Patch V1 07/30] mm: " Christoph Lameter
2014-07-11 14:42   ` Tejun Heo
2014-07-11 15:13     ` Christoph Lameter
2014-07-11 15:21       ` Tejun Heo
2014-07-11 15:33         ` Tejun Heo
2014-07-11 15:55           ` Christoph Lameter
2014-07-11 15:58             ` Tejun Heo
2014-07-11 16:04               ` Christoph Lameter
2014-07-11 15:58         ` Christoph Lameter
2014-07-11 16:01           ` Tejun Heo
2014-07-11 16:19             ` Christoph Lameter
2014-07-11 16:24               ` Tejun Heo
2014-07-11 17:29                 ` Christoph Lameter
2014-07-11 18:28                   ` Tejun Heo
2014-07-11 19:11                     ` Christoph Lameter
2014-07-23  3:16                       ` Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 08/30] mm, thp: " Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 09/30] mm, memcg: " Jiang Liu
2014-07-18  7:36   ` Michal Hocko
2014-07-23  3:18     ` Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 10/30] mm, xfrm: " Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 11/30] mm, char/mspec.c: " Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 12/30] mm, IB/qib: " Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 13/30] mm, i40e: " Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 14/30] mm, i40evf: " Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 15/30] mm, igb: " Jiang Liu
2014-07-21 17:42   ` Nishanth Aravamudan
     [not found]     ` <CAKgT0UdZdbduP-=R7uRCxJVxt1yCDoHpnercnDoyrCbWNtx=6Q@mail.gmail.com>
2014-07-21 21:09       ` Nishanth Aravamudan
2014-07-23  3:20         ` Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 16/30] mm, ixgbe: " Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 17/30] mm, intel_powerclamp: " Jiang Liu
2014-07-21 17:38   ` Nishanth Aravamudan
2014-07-11  7:37 ` [RFC Patch V1 18/30] mm, bnx2fc: " Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 19/30] mm, bnx2i: " Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 20/30] mm, fcoe: " Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 21/30] mm, irqchip: " Jiang Liu
2014-07-18 12:40   ` Jason Cooper
2014-07-23  3:47     ` Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 22/30] mm, of: " Jiang Liu
2014-07-21 17:52   ` Nishanth Aravamudan
2014-07-28 13:30     ` Grant Likely
2014-07-28 19:26       ` Nishanth Aravamudan
2014-07-11  7:37 ` [RFC Patch V1 23/30] mm, x86: " Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 24/30] mm, x86/platform/uv: " Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 25/30] mm, x86, kvm: " Jiang Liu
2014-07-11  7:44   ` Paolo Bonzini
2014-07-11  7:37 ` [RFC Patch V1 26/30] mm, x86, perf: " Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 27/30] x86, numa: Kill useless code to improve code readability Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 28/30] mm: Update _mem_id_[] for every possible CPU when memory configuration changes Jiang Liu
2014-07-21 17:47   ` Nishanth Aravamudan
2014-07-23  8:16     ` Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 29/30] mm, x86: Enable memoryless node support to better support CPU/memory hotplug Jiang Liu
2014-07-24 23:26   ` Nishanth Aravamudan
2014-07-25  1:41     ` Jiang Liu
2014-07-11  7:37 ` [RFC Patch V1 30/30] x86, NUMA: Online node earlier when doing CPU hot-addition Jiang Liu
2014-07-24 23:30   ` Nishanth Aravamudan
2014-07-25  1:43     ` Jiang Liu
2014-07-25  1:44     ` Jiang Liu
2014-07-11  8:29 ` [RFC Patch V1 00/30] Enable memoryless node on x86 platforms Peter Zijlstra
2014-07-11 15:33   ` Greg KH
2014-07-11 20:02     ` Dave Hansen
2014-07-11 20:20     ` Andi Kleen
2014-07-11 20:51       ` Peter Zijlstra
2014-07-11 21:58         ` Andi Kleen
2014-07-15  1:18         ` David Rientjes
2014-07-11 23:51       ` H. Peter Anvin
2014-07-11 22:40     ` Jiri Kosina
2014-07-15  1:19       ` David Rientjes
2014-07-21 17:23 ` Nishanth Aravamudan
2014-07-21 17:41   ` Tony Luck
2014-07-21 17:57     ` Nishanth Aravamudan
2014-07-23  8:20       ` Jiang Liu
2014-07-24 23:32         ` Nishanth Aravamudan
2014-07-25  1:50           ` Jiang Liu
2014-08-18 23:30             ` Nishanth Aravamudan
2014-07-21 20:06     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405064267-11678-8-git-send-email-jiang.liu@linux.intel.com \
    --to=jiang.liu@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=av1474@comtv.ru \
    --cc=catalin.marinas@arm.com \
    --cc=cl@linux-foundation.org \
    --cc=fabf@skynet.be \
    --cc=hannes@cmpxchg.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-hotplug@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liwanp@linux.vnet.ibm.com \
    --cc=mgorman@suse.de \
    --cc=nasa4836@gmail.com \
    --cc=peterz@infradead.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    --cc=tj@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=umgwanakikbuti@gmail.com \
    --cc=vdavydov@parallels.com \
    --cc=zhangyanfei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).