* [PATCH] cpuidle: fix permission for driver name sysfs node
@ 2014-07-12 13:29 Mohammad Merajul Islam Molla
2014-07-15 5:16 ` Mohammad Merajul Islam Molla
2014-07-22 23:54 ` Rafael J. Wysocki
0 siblings, 2 replies; 5+ messages in thread
From: Mohammad Merajul Islam Molla @ 2014-07-12 13:29 UTC (permalink / raw)
To: linux-pm
Cc: rjw, daniel.lezcano, linux-kernel, linaro-kernel,
Mohammad Merajul Islam Molla
cpuidle driver name sysfs node is read-only. So permission should be 0444.
Signed-off-by: Mohammad Merajul Islam Molla <meraj.enigma@gmail.com>
---
drivers/cpuidle/sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c
index efe2f17..97c5903 100644
--- a/drivers/cpuidle/sysfs.c
+++ b/drivers/cpuidle/sysfs.c
@@ -445,7 +445,7 @@ static void cpuidle_remove_state_sysfs(struct cpuidle_device *device)
#define define_one_driver_ro(_name, show) \
static struct cpuidle_driver_attr attr_driver_##_name = \
- __ATTR(_name, 0644, show, NULL)
+ __ATTR(_name, 0444, show, NULL)
struct cpuidle_driver_kobj {
struct cpuidle_driver *drv;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] cpuidle: fix permission for driver name sysfs node
2014-07-12 13:29 [PATCH] cpuidle: fix permission for driver name sysfs node Mohammad Merajul Islam Molla
@ 2014-07-15 5:16 ` Mohammad Merajul Islam Molla
2014-07-15 12:28 ` Rafael J. Wysocki
2014-07-22 23:54 ` Rafael J. Wysocki
1 sibling, 1 reply; 5+ messages in thread
From: Mohammad Merajul Islam Molla @ 2014-07-15 5:16 UTC (permalink / raw)
To: rjw; +Cc: Daniel Lezcano, linux-kernel, linux-pm,
Mohammad Merajul Islam Molla
Hi Rafael/Daniel,
Did you get a chance to review the patch?
--
Thanks,
-Meraj
On Sat, Jul 12, 2014 at 7:29 PM, Mohammad Merajul Islam Molla
<meraj.enigma@gmail.com> wrote:
> cpuidle driver name sysfs node is read-only. So permission should be 0444.
>
> Signed-off-by: Mohammad Merajul Islam Molla <meraj.enigma@gmail.com>
> ---
> drivers/cpuidle/sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c
> index efe2f17..97c5903 100644
> --- a/drivers/cpuidle/sysfs.c
> +++ b/drivers/cpuidle/sysfs.c
> @@ -445,7 +445,7 @@ static void cpuidle_remove_state_sysfs(struct cpuidle_device *device)
>
> #define define_one_driver_ro(_name, show) \
> static struct cpuidle_driver_attr attr_driver_##_name = \
> - __ATTR(_name, 0644, show, NULL)
> + __ATTR(_name, 0444, show, NULL)
>
> struct cpuidle_driver_kobj {
> struct cpuidle_driver *drv;
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] cpuidle: fix permission for driver name sysfs node
2014-07-15 5:16 ` Mohammad Merajul Islam Molla
@ 2014-07-15 12:28 ` Rafael J. Wysocki
2014-07-15 13:24 ` Mohammad Merajul Islam Molla
0 siblings, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2014-07-15 12:28 UTC (permalink / raw)
To: Mohammad Merajul Islam Molla; +Cc: Daniel Lezcano, linux-kernel, linux-pm
On Tuesday, July 15, 2014 11:16:40 AM Mohammad Merajul Islam Molla wrote:
> Hi Rafael/Daniel,
>
> Did you get a chance to review the patch?
We will review it. Why is this urgent?
Rafael
> On Sat, Jul 12, 2014 at 7:29 PM, Mohammad Merajul Islam Molla
> <meraj.enigma@gmail.com> wrote:
> > cpuidle driver name sysfs node is read-only. So permission should be 0444.
> >
> > Signed-off-by: Mohammad Merajul Islam Molla <meraj.enigma@gmail.com>
> > ---
> > drivers/cpuidle/sysfs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c
> > index efe2f17..97c5903 100644
> > --- a/drivers/cpuidle/sysfs.c
> > +++ b/drivers/cpuidle/sysfs.c
> > @@ -445,7 +445,7 @@ static void cpuidle_remove_state_sysfs(struct cpuidle_device *device)
> >
> > #define define_one_driver_ro(_name, show) \
> > static struct cpuidle_driver_attr attr_driver_##_name = \
> > - __ATTR(_name, 0644, show, NULL)
> > + __ATTR(_name, 0444, show, NULL)
> >
> > struct cpuidle_driver_kobj {
> > struct cpuidle_driver *drv;
> > --
> > 1.9.1
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] cpuidle: fix permission for driver name sysfs node
2014-07-15 12:28 ` Rafael J. Wysocki
@ 2014-07-15 13:24 ` Mohammad Merajul Islam Molla
0 siblings, 0 replies; 5+ messages in thread
From: Mohammad Merajul Islam Molla @ 2014-07-15 13:24 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Daniel Lezcano, linux-kernel, linux-pm
Thanks. Its not actually :).
On Tue, Jul 15, 2014 at 6:28 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> On Tuesday, July 15, 2014 11:16:40 AM Mohammad Merajul Islam Molla wrote:
>> Hi Rafael/Daniel,
>>
>> Did you get a chance to review the patch?
>
> We will review it. Why is this urgent?
>
> Rafael
>
>
>> On Sat, Jul 12, 2014 at 7:29 PM, Mohammad Merajul Islam Molla
>> <meraj.enigma@gmail.com> wrote:
>> > cpuidle driver name sysfs node is read-only. So permission should be 0444.
>> >
>> > Signed-off-by: Mohammad Merajul Islam Molla <meraj.enigma@gmail.com>
>> > ---
>> > drivers/cpuidle/sysfs.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c
>> > index efe2f17..97c5903 100644
>> > --- a/drivers/cpuidle/sysfs.c
>> > +++ b/drivers/cpuidle/sysfs.c
>> > @@ -445,7 +445,7 @@ static void cpuidle_remove_state_sysfs(struct cpuidle_device *device)
>> >
>> > #define define_one_driver_ro(_name, show) \
>> > static struct cpuidle_driver_attr attr_driver_##_name = \
>> > - __ATTR(_name, 0644, show, NULL)
>> > + __ATTR(_name, 0444, show, NULL)
>> >
>> > struct cpuidle_driver_kobj {
>> > struct cpuidle_driver *drv;
>> > --
>> > 1.9.1
>> >
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] cpuidle: fix permission for driver name sysfs node
2014-07-12 13:29 [PATCH] cpuidle: fix permission for driver name sysfs node Mohammad Merajul Islam Molla
2014-07-15 5:16 ` Mohammad Merajul Islam Molla
@ 2014-07-22 23:54 ` Rafael J. Wysocki
1 sibling, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2014-07-22 23:54 UTC (permalink / raw)
To: Mohammad Merajul Islam Molla
Cc: linux-pm, daniel.lezcano, linux-kernel, linaro-kernel
On Saturday, July 12, 2014 07:29:22 PM Mohammad Merajul Islam Molla wrote:
> cpuidle driver name sysfs node is read-only. So permission should be 0444.
>
> Signed-off-by: Mohammad Merajul Islam Molla <meraj.enigma@gmail.com>
Queued up for 3.17, thanks!
> ---
> drivers/cpuidle/sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c
> index efe2f17..97c5903 100644
> --- a/drivers/cpuidle/sysfs.c
> +++ b/drivers/cpuidle/sysfs.c
> @@ -445,7 +445,7 @@ static void cpuidle_remove_state_sysfs(struct cpuidle_device *device)
>
> #define define_one_driver_ro(_name, show) \
> static struct cpuidle_driver_attr attr_driver_##_name = \
> - __ATTR(_name, 0644, show, NULL)
> + __ATTR(_name, 0444, show, NULL)
>
> struct cpuidle_driver_kobj {
> struct cpuidle_driver *drv;
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-07-22 23:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-12 13:29 [PATCH] cpuidle: fix permission for driver name sysfs node Mohammad Merajul Islam Molla
2014-07-15 5:16 ` Mohammad Merajul Islam Molla
2014-07-15 12:28 ` Rafael J. Wysocki
2014-07-15 13:24 ` Mohammad Merajul Islam Molla
2014-07-22 23:54 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).