From: Adithya Krishnamurthy <linux.challenge1@gmail.com>
To: omar.ramirez@copitl.com, gregkh@linuxfoundation.org,
rashika.kheria@gmail.com, freemangordon@abv.bg,
dan.carpenter@oracle.com, ody.guru@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Cc: Adithya Krishnamurthy <linux.challenge1@gmail.com>
Subject: [PATCH] Staging:tidspbridge Fix checkpatch.pl warning char * array declaration might be better as static const
Date: Tue, 15 Jul 2014 22:18:18 +0530 [thread overview]
Message-ID: <1405442900-6977-1-git-send-email-linux.challenge1@gmail.com> (raw)
In-Reply-To: <y>
From: Adithya Krishnamurthy <linux.challenge1@gmail.com>
Fixed checkpatch "WARNING: char * array declaration might be better as static const"
Signed-off-by: Adithya Krishnamurthy <linux.challenge1@gmail.com>
---
drivers/staging/tidspbridge/core/io_sm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/tidspbridge/core/io_sm.c b/drivers/staging/tidspbridge/core/io_sm.c
index 42f94e1..24bd962 100644
--- a/drivers/staging/tidspbridge/core/io_sm.c
+++ b/drivers/staging/tidspbridge/core/io_sm.c
@@ -1910,10 +1910,11 @@ int dump_dsp_stack(struct bridge_dev_context *bridge_context)
u32 offset_output;
u32 total_size;
u32 poll_cnt;
- const char *dsp_regs[] = {"EFR", "IERR", "ITSR", "NTSR",
+ static const char * const dsp_regs[] = {"EFR", "IERR", "ITSR", "NTSR",
"IRP", "NRP", "AMR", "SSR",
"ILC", "RILC", "IER", "CSR"};
- const char *exec_ctxt[] = {"Task", "SWI", "HWI", "Unknown"};
+ static const char * const exec_ctxt[] = {"Task", "SWI", "HWI",
+ "Unknown"};
struct bridge_drv_interface *intf_fxns;
struct dev_object *dev_object = bridge_context->dev_obj;
--
1.7.9.5
next reply other threads:[~2014-07-15 16:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 16:48 Adithya Krishnamurthy [this message]
2014-07-15 16:48 ` [PATCH] Staging:tidspbridge Fix minor checkpatch.pl warning unnecessary whitespace before a quoted newline Adithya Krishnamurthy
2014-07-15 16:48 ` [PATCH] Staging:tidspbridge Fix minor checkpatch.pl warining Unnecessary parentheses Adithya Krishnamurthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405442900-6977-1-git-send-email-linux.challenge1@gmail.com \
--to=linux.challenge1@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=freemangordon@abv.bg \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ody.guru@gmail.com \
--cc=omar.ramirez@copitl.com \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox