From: Joe Perches <joe@perches.com>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] scripts/get_maintainer: increase threshold for --follow to reduce time
Date: Tue, 15 Jul 2014 21:08:42 -0700 [thread overview]
Message-ID: <1405483722.14773.12.camel@joe-AO725> (raw)
In-Reply-To: <CAJhHMCC1bY5ras7-W17Qh7yZq5-_eD0C-CJfa09ZpjWNoTOZ=w@mail.gmail.com>
On Tue, 2014-07-15 at 22:23 -0400, Pranith Kumar wrote:
> ping?
>
> On Sat, Jul 12, 2014 at 3:25 PM, Pranith Kumar <bobby.prani@gmail.com> wrote:
> > get_maintainer tries to follow files with a matching threshold of default 50%.
> > This is not really necessary as we do not change a file and move it in the same
> > commit usually. Increasing the threshold to 90% should be sufficient.
[]
> > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> > index d701627..bc4a69e 100755
> > --- a/scripts/get_maintainer.pl
> > +++ b/scripts/get_maintainer.pl
> > @@ -98,7 +98,7 @@ my %VCS_cmds_git = (
> > "execute_cmd" => \&git_execute_cmd,
> > "available" => '(which("git") ne "") && (-e ".git")',
> > "find_signers_cmd" =>
> > - "git log --no-color --follow --since=\$email_git_since " .
> > + "git log --no-color --follow -M90 --since=\$email_git_since " .
> > '--numstat --no-merges ' .
> > '--format="GitCommit: %H%n' .
> > 'GitAuthor: %an <%ae>%n' .
While I understand the goal, I wonder if this should
be in a .gitconfig, not in get_maintainers at all.
(git doesn't seem to have a config entry for score though)
If not, the % should probably be cmd-line configurable.
next prev parent reply other threads:[~2014-07-16 4:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-12 19:25 [PATCH 1/1] scripts/get_maintainer: increase threshold for --follow to reduce time Pranith Kumar
2014-07-16 2:23 ` Pranith Kumar
2014-07-16 4:08 ` Joe Perches [this message]
2014-07-16 4:35 ` Pranith Kumar
2014-07-16 4:50 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405483722.14773.12.camel@joe-AO725 \
--to=joe@perches.com \
--cc=bobby.prani@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).