From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752168AbaGPUDZ (ORCPT ); Wed, 16 Jul 2014 16:03:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50858 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752088AbaGPUDS (ORCPT ); Wed, 16 Jul 2014 16:03:18 -0400 From: Jiri Olsa To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Andi Kleen , Jiri Olsa Subject: [PATCH 10/13] perf tools: Query terminal width and use in perf list Date: Wed, 16 Jul 2014 22:02:46 +0200 Message-Id: <1405540969-18975-11-git-send-email-jolsa@kernel.org> In-Reply-To: <1405540969-18975-1-git-send-email-jolsa@kernel.org> References: <1405540969-18975-1-git-send-email-jolsa@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andi Kleen Automatically adapt the now wider and word wrapped perf list output to wider terminals. This requires querying the terminal before the auto pager takes over, and exporting this information from the pager subsystem. Signed-off-by: Andi Kleen Acked-by: Namhyung Kim Link: http://lkml.kernel.org/n/1405123165-22666-9-git-send-email-andi@firstfloor.org Signed-off-by: Jiri Olsa --- tools/perf/util/cache.h | 1 + tools/perf/util/pager.c | 15 +++++++++++++++ tools/perf/util/pmu.c | 12 ++---------- 3 files changed, 18 insertions(+), 10 deletions(-) diff --git a/tools/perf/util/cache.h b/tools/perf/util/cache.h index 7b176dd02e1a..07527d652f92 100644 --- a/tools/perf/util/cache.h +++ b/tools/perf/util/cache.h @@ -31,6 +31,7 @@ extern void setup_pager(void); extern const char *pager_program; extern int pager_in_use(void); extern int pager_use_color; +int pager_get_columns(void); char *alias_lookup(const char *alias); int split_cmdline(char *cmdline, const char ***argv); diff --git a/tools/perf/util/pager.c b/tools/perf/util/pager.c index 31ee02d4e988..9761202f7f3a 100644 --- a/tools/perf/util/pager.c +++ b/tools/perf/util/pager.c @@ -1,6 +1,7 @@ #include "cache.h" #include "run-command.h" #include "sigchain.h" +#include /* * This is split up from the rest of git so that we can do @@ -8,6 +9,7 @@ */ static int spawned_pager; +static int pager_columns; static void pager_preexec(void) { @@ -47,9 +49,12 @@ static void wait_for_pager_signal(int signo) void setup_pager(void) { const char *pager = getenv("PERF_PAGER"); + struct winsize sz; if (!isatty(1)) return; + if (ioctl(1, TIOCGWINSZ, &sz) == 0) + pager_columns = sz.ws_col; if (!pager) { if (!pager_program) perf_config(perf_default_config, NULL); @@ -98,3 +103,13 @@ int pager_in_use(void) env = getenv("PERF_PAGER_IN_USE"); return env ? perf_config_bool("PERF_PAGER_IN_USE", env) : 0; } + +int pager_get_columns(void) +{ + char *s; + + s = getenv("COLUMNS"); + if (s) + return atoi(s); + return (pager_columns ? pager_columns : 80) - 2; +} diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index fa2131947ad3..8714f9a11abe 100644 --- a/tools/perf/util/pmu.c +++ b/tools/perf/util/pmu.c @@ -9,6 +9,7 @@ #include "pmu.h" #include "parse-events.h" #include "cpumap.h" +#include "cache.h" #include "jevents.h" const char *json_file; @@ -789,15 +790,6 @@ static void wordwrap(char *s, int start, int max, int corr) } } -static int get_columns(void) -{ - /* - * Should ask the terminal with TIOCGWINSZ here, but we - * need the original fd before the pager. - */ - return 79; -} - void print_pmu_events(const char *event_glob, bool name_only) { struct perf_pmu *pmu; @@ -807,7 +799,7 @@ void print_pmu_events(const char *event_glob, bool name_only) int len, j; struct pair *aliases; int numdesc = 0; - int columns = get_columns(); + int columns = pager_get_columns(); pmu = NULL; len = 0; -- 1.8.3.1