From: Nicholas Krause <xerofoify@gmail.com>
To: gregkh@linuxfoundation.org
Cc: stern@rowland.harvard.edu, mail@beyermatthias.de,
hdegoede@redhat.com, dan.j.williams@intel.com,
valentine.barshak@cogentembedded.com, ming.lei@canonical.com,
michael.opdenacker@free-electrons.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] usb-core: Remove Fix mes in file hcd.c
Date: Fri, 18 Jul 2014 13:34:40 -0400 [thread overview]
Message-ID: <1405704880-10036-1-git-send-email-xerofoify@gmail.com> (raw)
I am removing two fix mes in this file as after dicussing then it seems
there is no reason to check against Null for usb_device as it can never
be NULL and this is check is therefore not needed.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
drivers/usb/core/hcd.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index bec31e2..487abcf 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -855,8 +855,6 @@ static ssize_t authorized_default_show(struct device *dev,
struct usb_bus *usb_bus = rh_usb_dev->bus;
struct usb_hcd *usb_hcd;
- if (usb_bus == NULL) /* FIXME: not sure if this case is possible */
- return -ENODEV;
usb_hcd = bus_to_hcd(usb_bus);
return snprintf(buf, PAGE_SIZE, "%u\n", usb_hcd->authorized_default);
}
@@ -871,8 +869,6 @@ static ssize_t authorized_default_store(struct device *dev,
struct usb_bus *usb_bus = rh_usb_dev->bus;
struct usb_hcd *usb_hcd;
- if (usb_bus == NULL) /* FIXME: not sure if this case is possible */
- return -ENODEV;
usb_hcd = bus_to_hcd(usb_bus);
result = sscanf(buf, "%u\n", &val);
if (result == 1) {
--
1.9.1
next reply other threads:[~2014-07-18 17:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 17:34 Nicholas Krause [this message]
2014-07-18 19:09 ` [PATCH] usb-core: Remove Fix mes in file hcd.c Alan Stern
2014-07-18 19:55 ` Nick Krause
2014-07-19 2:36 ` Sasha Levin
2014-07-19 2:45 ` Nick Krause
2014-07-19 2:52 ` Nick Krause
2014-07-23 0:44 ` Sasha Levin
2014-07-23 3:24 ` Nick Krause
2014-07-24 13:07 ` Vlastimil Babka
2014-07-24 16:17 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405704880-10036-1-git-send-email-xerofoify@gmail.com \
--to=xerofoify@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@beyermatthias.de \
--cc=michael.opdenacker@free-electrons.com \
--cc=ming.lei@canonical.com \
--cc=stern@rowland.harvard.edu \
--cc=valentine.barshak@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).