Re: [PATCH 52/52] perf tools: Add support for 32-bit compatibility VDSOs

Namhyung Kim
2014-07-23T23:35:32Z

Hi Adrian,

On Wed, 23 Jul 2014 16:59:39 +0300, Adrian Hunter wrote:
> On 07/23/2014 04:02 PM, Jiri Olsa wrote:
>> On Tue, Jul 22, 2014 at 04:18:01PM +0300, Adrian Hunter wrote:
>>> 'perf record' post-processes the event stream to create
>>> a list of build-ids for object files for which sample
>>> events have been recorded. That results in those object
>>> files being recorded in the build-id cache.
>>
>> SNIP
>>
>>>
>>> if (vdso_info->vdso.found)
>>> unlink(vdso_info->vdso.temp_file_name);
>>> +#if BITS_PER_LONG == 64
>>> + if (vdso_info->vdso32.found)
>>> + unlink(vdso_info->vdso.temp_file_name);
>>> + if (vdso_info->vdsox32.found)
>>> + unlink(vdso_info->vdso.temp_file_name);
>>> +#endif

Looks like copy-and-paste errors. Did you mean below?

#if BITS_PER_LONG == 64
if (vdso_info->vdso32.found)
unlink(vdso_info->vdso32.temp_file_name);
if (vdso_info->vdsox32.found)
unlink(vdso_info->vdsox32.temp_file_name);
#endif

^^^

Thanks,
Namhyung