From: Pranith Kumar <bobby.prani@gmail.com>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
linux-kernel@vger.kernel.org (open list:READ-COPY UPDATE...)
Subject: [PATCH 01/16] rcu: Use rcu_num_nodes instead of NUM_RCU_NODES
Date: Wed, 23 Jul 2014 01:09:38 -0400 [thread overview]
Message-ID: <1406092194-13004-2-git-send-email-bobby.prani@gmail.com> (raw)
In-Reply-To: <1406092194-13004-1-git-send-email-bobby.prani@gmail.com>
NUM_RCU_NODES is set at build time and is usually a huge number. We calculate
the actual number of rcu nodes necessary at boot time based on nr_cpu_ids in
rcu_init_geometry() and store it in rcu_num_nodes. We should use this variable
instead of NUM_RCU_NODES.
This commit changes all such NUM_RCU_NODES uses to rcu_num_nodes.
Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
---
kernel/rcu/tree_plugin.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
index c31eb28..f07b643 100644
--- a/kernel/rcu/tree_plugin.h
+++ b/kernel/rcu/tree_plugin.h
@@ -885,7 +885,7 @@ void synchronize_rcu_expedited(void)
/* Snapshot current state of ->blkd_tasks lists. */
rcu_for_each_leaf_node(rsp, rnp)
sync_rcu_preempt_exp_init(rsp, rnp);
- if (NUM_RCU_NODES > 1)
+ if (rcu_num_nodes > 1)
sync_rcu_preempt_exp_init(rsp, rcu_get_root(rsp));
put_online_cpus();
@@ -1475,7 +1475,7 @@ static void __init rcu_spawn_boost_kthreads(void)
BUG_ON(smpboot_register_percpu_thread(&rcu_cpu_thread_spec));
rnp = rcu_get_root(rcu_state_p);
(void)rcu_spawn_one_boost_kthread(rcu_state_p, rnp);
- if (NUM_RCU_NODES > 1) {
+ if (rcu_num_nodes > 1) {
rcu_for_each_leaf_node(rcu_state_p, rnp)
(void)rcu_spawn_one_boost_kthread(rcu_state_p, rnp);
}
--
2.0.0.rc2
next prev parent reply other threads:[~2014-07-23 5:10 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 5:09 [PATCH 00/16] rcu: Some minor fixes and cleanups Pranith Kumar
2014-07-23 5:09 ` Pranith Kumar [this message]
2014-07-23 5:09 ` [PATCH 02/16] rcu: Check return value for cpumask allocation Pranith Kumar
2014-07-23 12:06 ` Paul E. McKenney
2014-07-23 12:49 ` Pranith Kumar
2014-07-23 17:14 ` Pranith Kumar
2014-07-23 18:01 ` Paul E. McKenney
2014-07-23 5:09 ` [PATCH 03/16] rcu: Fix comment for gp_state field values Pranith Kumar
2014-07-23 5:09 ` [PATCH 04/16] rcu: Remove redundant check for an online CPU Pranith Kumar
2014-07-23 12:09 ` Paul E. McKenney
2014-07-23 13:23 ` Pranith Kumar
2014-07-23 13:41 ` Paul E. McKenney
2014-07-23 14:01 ` Pranith Kumar
2014-07-23 14:14 ` Paul E. McKenney
2014-07-23 15:07 ` Pranith Kumar
2014-07-23 15:21 ` Pranith Kumar
2014-07-23 5:09 ` [PATCH 05/16] rcu: Add noreturn attribute to boost kthread Pranith Kumar
2014-07-23 5:09 ` [PATCH 06/16] rcu: Clear gp_flags only when actually starting new gp Pranith Kumar
2014-07-23 12:13 ` Paul E. McKenney
2014-07-23 5:09 ` [PATCH 07/16] rcu: Save and restore irq flags in rcu_gp_cleanup() Pranith Kumar
2014-07-23 12:16 ` Paul E. McKenney
2014-07-23 5:09 ` [PATCH 08/16] rcu: Clean up rcu_spawn_one_boost_kthread() Pranith Kumar
2014-07-23 5:09 ` [PATCH 09/16] rcu: Remove redundant check for online cpu Pranith Kumar
2014-07-23 12:21 ` Paul E. McKenney
2014-07-23 12:59 ` Pranith Kumar
2014-07-23 13:50 ` Paul E. McKenney
2014-07-23 14:12 ` Pranith Kumar
2014-07-23 14:23 ` Paul E. McKenney
2014-07-23 15:11 ` Pranith Kumar
2014-07-23 15:30 ` Paul E. McKenney
2014-07-23 15:44 ` Pranith Kumar
2014-07-23 19:15 ` Paul E. McKenney
2014-07-23 20:01 ` Pranith Kumar
2014-07-23 20:16 ` Pranith Kumar
2014-07-23 20:23 ` Paul E. McKenney
2014-07-23 5:09 ` [PATCH 10/16] rcu: Check for RCU_FLAG_GP_INIT bit in gp_flags for spurious wakeup Pranith Kumar
2014-07-23 12:23 ` Paul E. McKenney
2014-07-23 5:09 ` [PATCH 11/16] rcu: Check for spurious wakeup using return value Pranith Kumar
2014-07-23 12:26 ` Paul E. McKenney
2014-07-24 2:36 ` Pranith Kumar
2014-07-24 3:43 ` Paul E. McKenney
2014-07-24 4:03 ` Pranith Kumar
2014-07-24 18:12 ` Paul E. McKenney
2014-07-24 19:59 ` Pranith Kumar
2014-07-24 20:27 ` Paul E. McKenney
2014-07-23 5:09 ` [PATCH 12/16] rcu: Rename rcu_spawn_gp_kthread() to rcu_spawn_kthreads() Pranith Kumar
2014-07-23 5:09 ` [PATCH 13/16] rcu: Spawn nocb kthreads from rcu_prepare_kthreads() Pranith Kumar
2014-07-23 5:09 ` [PATCH 14/16] rcu: Remove redundant checks for rcu_scheduler_fully_active Pranith Kumar
2014-07-23 12:27 ` Paul E. McKenney
2014-07-23 5:09 ` [PATCH 15/16] rcu: Check for a nocb cpu before trying to spawn nocb threads Pranith Kumar
2014-07-23 12:28 ` Paul E. McKenney
2014-07-23 13:14 ` Pranith Kumar
2014-07-23 13:42 ` Paul E. McKenney
2014-07-23 5:09 ` [PATCH 16/16] rcu: kvm.sh: Fix error when you pass --cpus argument Pranith Kumar
2014-07-23 12:31 ` Paul E. McKenney
2014-07-23 14:45 ` [PATCH 00/16] rcu: Some minor fixes and cleanups Paul E. McKenney
2014-08-27 1:10 ` Pranith Kumar
2014-08-27 3:20 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406092194-13004-2-git-send-email-bobby.prani@gmail.com \
--to=bobby.prani@gmail.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox