Re: [PATCH 13/52] perf tools: Add perf_pmu__scan_file()

Jiri Olsa
2014-07-23T09:37:17Z

On Wed, Jul 23, 2014 at 09:24:49AM +0300, Adrian Hunter wrote:
> On 07/22/2014 10:09 PM, Jiri Olsa wrote:
> > On Tue, Jul 22, 2014 at 04:17:22PM +0300, Adrian Hunter wrote:
> >
> > SNIP
> >
> >> +
> >> +static FILE *perf_pmu__open_file(struct perf_pmu *pmu, const char *name)
> >> +{
> >> + struct stat st;
> >> + char path[PATH_MAX];
> >> + const char *sysfs;
> >> +
> >> + sysfs = sysfs__mountpoint();
> >> + if (!sysfs)
> >> + return NULL;
> >> +
> >> + snprintf(path, PATH_MAX,
> >> + "%s" EVENT_SOURCE_DEVICE_PATH "%s/%s", sysfs, pmu->name, name);
> >> +
> >> + if (stat(path, &st) < 0)
> >> + return NULL;
> >> +
> >> + return fopen(path, "r");
> >> +}
> >
> > looks like this function could be used in pmu_cpumask and pmu_type
> > and maybe others
>
> There is existing code duplication between them. Given the large number of
> patches I would say it is easier to deal with that separately.

ook, jirka