Re: [PATCH 52/52] perf tools: Add support for 32-bit compatibility VDSOs

Adrian Hunter
2014-07-23T14:01:28Z

On 07/23/2014 04:02 PM, Jiri Olsa wrote:
> On Tue, Jul 22, 2014 at 04:18:01PM +0300, Adrian Hunter wrote:
>> 'perf record' post-processes the event stream to create
>> a list of build-ids for object files for which sample
>> events have been recorded. That results in those object
>> files being recorded in the build-id cache.
>
> SNIP
>
>>
>> if (vdso_info->vdso.found)
>> unlink(vdso_info->vdso.temp_file_name);
>> +#if BITS_PER_LONG == 64
>> + if (vdso_info->vdso32.found)
>> + unlink(vdso_info->vdso.temp_file_name);
>> + if (vdso_info->vdsox32.found)
>> + unlink(vdso_info->vdso.temp_file_name);
>> +#endif
>>
>> zfree(&machine->vdso_info);
>> }
>> @@ -135,6 +159,143 @@ static struct dso *vdso__new(struct machine *machine, const char *short_name,
>> return dso;
>> }
>>
>> +#if BITS_PER_LONG == 64
>
> Does this define mean all 64 archs? Do we want other than x86 in here?
> (all of its instances)

Any 64-bit arch can have 32-bit compatibility VDSOs. This should
be OK for other arches too.

>
> jirka
>
>> +
>> +static enum dso_type machine__thread_dso_type(struct machine *machine,
>> + struct thread *thread)
>> +{
>> + enum dso_type dso_type = DSO__TYPE_UNKNOWN;
>> + struct map *map;
>> + struct dso *dso;
>> +
>> + map = map_groups__first(thread->mg, MAP__FUNCTION);
>> + for (; map ; map = map_groups__next(map)) {
>> + dso = map->dso;
>> + if (!dso || dso->long_name[0] != '/')
>> + continue;
>> + dso_type = dso__type(dso, machine);
>> + if (dso_type != DSO__TYPE_UNKNOWN)
>> + break;
>> + }
>> +
>> + return dso_type;
>> +}
>
> SNIP
>
>