From: Oliver Neukum <oneukum@suse.de>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, joe@perches.com,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, usb-storage@lists.one-eyed-alien.net
Subject: Re: [PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return
Date: Thu, 24 Jul 2014 13:37:20 +0200 [thread overview]
Message-ID: <1406201840.729.4.camel@linux-fkkt.site> (raw)
In-Reply-To: <1406189939-6433-1-git-send-email-fabf@skynet.be>
On Thu, 2014-07-24 at 10:18 +0200, Fabian Frederick wrote:
> Small patchset addressing break redundancy on drivers/usb branch
> (suggested by Joe Perches).
Frankly, that is not a good idea. Somebody will remove a "goto"
and forget to readd the "break"
Regards
Oliver
next prev parent reply other threads:[~2014-07-24 11:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 8:18 [PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return Fabian Frederick
2014-07-24 8:18 ` [PATCH 01/10 linux-next] USB: iowarrior: remove unnecessary break after goto Fabian Frederick
2014-07-24 8:18 ` [PATCH 02/10 linux-next] USB: usblcd: remove unnecessary break after return Fabian Frederick
2014-07-24 8:18 ` [PATCH 03/10 linux-next] usb: dcw3: " Fabian Frederick
2014-07-24 8:18 ` [PATCH 04/10 linux-next] usb: gadget: " Fabian Frederick
2014-07-24 8:18 ` [PATCH 05/10 linux-next] usb: gadget: remove unnecessary break after goto Fabian Frederick
2014-07-24 8:18 ` [PATCH 06/10 linux-next] xhci: remove unnecessary break after return Fabian Frederick
2014-07-24 11:43 ` Mathias Nyman
2014-07-24 8:18 ` [PATCH 07/10 linux-next] usb: storage: " Fabian Frederick
2014-07-24 8:18 ` [PATCH 08/10 linux-next] USB: serial: " Fabian Frederick
2014-07-24 8:18 ` [PATCH 09/10 linux-next] USB: ftdi_sio: " Fabian Frederick
2014-07-24 8:24 ` [PATCH 10/10 linux-next] USB: microtek: remove unnecessary break after goto Fabian Frederick
2014-07-24 11:37 ` Oliver Neukum [this message]
2014-07-24 15:46 ` [PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return Fabian Frederick
2014-07-24 15:52 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406201840.729.4.camel@linux-fkkt.site \
--to=oneukum@suse.de \
--cc=fabf@skynet.be \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox