From: Paul Bolle <pebolle@tiscali.nl>
To: Seunghun Lee <waydi1@gmail.com>
Cc: gregkh@linuxfoundation.org, lidza.louina@gmail.com,
markh@compro.net, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: dgnc: Fix do not initialise statics to 0 or NULL
Date: Thu, 24 Jul 2014 18:44:52 +0200 [thread overview]
Message-ID: <1406220292.12720.2.camel@x41> (raw)
In-Reply-To: <1406215613-9314-2-git-send-email-waydi1@gmail.com>
Seunghun Lee schreef op vr 25-07-2014 om 00:26 [+0900]:
> This patch fixes checkpatch errors
> "do not initialise statics to 0 or NULL"
>
> Signed-off-by: Seunghun Lee <waydi1@gmail.com>
> ---
> drivers/staging/dgnc/dgnc_trace.c | 2 +-
> drivers/staging/dgnc/dgnc_tty.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_trace.c b/drivers/staging/dgnc/dgnc_trace.c
> index 2f62f2a..9be4715 100644
> --- a/drivers/staging/dgnc/dgnc_trace.c
> +++ b/drivers/staging/dgnc/dgnc_trace.c
> @@ -43,7 +43,7 @@
> static char *dgnc_trcbuf; /* the ringbuffer */
>
> #if defined(TRC_TO_KMEM)
> -static int dgnc_trcbufi = 0; /* index of the tilde at the end of */
> +static int dgnc_trcbufi; /* index of the tilde at the end of */
> #endif
I don't think TRC_TO_KMEM is defined anywhere. If that's correct, the
proper, well, fix for this checkpatch warning would be to remove all
code currently hidden behind the tests for that macro.
> #if defined(TRC_TO_KMEM)
Paul Bolle
next prev parent reply other threads:[~2014-07-24 16:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 15:26 [PATCH 1/3] staging: dgng: Fix Macros with complex values should be enclosed in parenthesis Seunghun Lee
2014-07-24 15:26 ` [PATCH 2/3] staging: dgnc: Fix do not initialise statics to 0 or NULL Seunghun Lee
2014-07-24 16:44 ` Paul Bolle [this message]
2014-07-24 15:26 ` [PATCH 3/3] staging: dgnc: Fix space required after that ',' Seunghun Lee
2014-07-24 17:52 ` [PATCH 1/3] staging: dgng: Fix Macros with complex values should be enclosed in parenthesis Joe Perches
2014-07-25 10:49 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406220292.12720.2.camel@x41 \
--to=pebolle@tiscali.nl \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
--cc=waydi1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox