From: Michael Ellerman <mpe@ellerman.id.au>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: andi@firstfloor.org, Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] powerpc/perf: Implement get_cpu_str()
Date: Fri, 25 Jul 2014 12:55:41 +1000 [thread overview]
Message-ID: <1406256941.8481.1.camel@concordia> (raw)
In-Reply-To: <20140724074749.GC18829@us.ibm.com>
On Thu, 2014-07-24 at 00:47 -0700, Sukadev Bhattiprolu wrote:
> [RFC PATCH 2/2] powerpc/perf: Implement get_cpu_str()
>
> get_cpu_str() returns a string identifying the CPU type on the system.
> This string is then used to locate a cached JSON file which defines
> the list of PMU events supported by the CPU.
>
> Eg: if get_cpu_str() returns "power8", the perf tool would refer to the
> PMU events defined in ~/.cache/pmu-events/power8.json.
Hi Suka,
I know we talked internally a while ago about using AT_BASE_PLATFORM, but that
was before I looked closely at Andi's patches last week.
I think we're better off using the PVR directly, it's less magic, it gives us
more flexibility and it's easier to get at.
So get_cpu_str() would just return eg. "004b0201-core".
We would handle the mapping of that name to an event file either in the
download script via the mapfile, or just by using symlinks.
cheers
prev parent reply other threads:[~2014-07-25 2:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 7:46 [RFC PATCH 0/2] powerpc/perf: Implement get_cpu_str() Sukadev Bhattiprolu
2014-07-24 7:47 ` [RFC PATCH 1/2] powerpc/perf: include util/util.h and remove stringify macros Sukadev Bhattiprolu
2014-07-24 14:02 ` Arnaldo Carvalho de Melo
2014-07-28 8:26 ` [tip:perf/core] perf powerpc: Include util/ util.h " tip-bot for Sukadev Bhattiprolu
2014-07-24 7:47 ` [RFC PATCH 2/2] powerpc/perf: Implement get_cpu_str() Sukadev Bhattiprolu
2014-07-25 2:55 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406256941.8481.1.camel@concordia \
--to=mpe@ellerman.id.au \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox