public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Low <jason.low2@hp.com>
To: Davidlohr Bueso <davidlohr@hp.com>
Cc: peterz@infradead.org, mingo@kernel.org, aswin@hp.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -tip/master 3/7] locking/mcs: Remove obsolete comment
Date: Mon, 28 Jul 2014 09:49:35 -0700	[thread overview]
Message-ID: <1406566175.2411.13.camel@j-VirtualBox> (raw)
In-Reply-To: <1406524724-17946-3-git-send-email-davidlohr@hp.com>

On Sun, 2014-07-27 at 22:18 -0700, Davidlohr Bueso wrote:
> ... as we clearly inline mcs_spin_lock() now.
> 
> Signed-off-by: Davidlohr Bueso <davidlohr@hp.com>
> ---
>  kernel/locking/mcs_spinlock.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/kernel/locking/mcs_spinlock.h b/kernel/locking/mcs_spinlock.h
> index 23e89c5..4d60986 100644
> --- a/kernel/locking/mcs_spinlock.h
> +++ b/kernel/locking/mcs_spinlock.h
> @@ -56,9 +56,6 @@ do {									\
>   * If the lock has already been acquired, then this will proceed to spin
>   * on this node->locked until the previous lock holder sets the node->locked
>   * in mcs_spin_unlock().
> - *
> - * We don't inline mcs_spin_lock() so that perf can correctly account for the
> - * time spent in this lock function.
>   */
>  static inline
>  void mcs_spin_lock(struct mcs_spinlock **lock, struct mcs_spinlock *node)

Likewise, I'm wondering if we should make this function noinline so that
"perf can correctly account for the time spent in this lock function".



  reply	other threads:[~2014-07-28 16:49 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-28  5:18 [PATCH -tip/master 1/7] locking/mutex: Unify arguments in lock/unlock slowpaths Davidlohr Bueso
2014-07-28  5:18 ` [PATCH -tip/master 2/7] locking/mutex: Document quick lock release when unlocking Davidlohr Bueso
2014-07-30 15:10   ` Jason Low
2014-07-30 18:20     ` Davidlohr Bueso
2014-07-28  5:18 ` [PATCH -tip/master 3/7] locking/mcs: Remove obsolete comment Davidlohr Bueso
2014-07-28 16:49   ` Jason Low [this message]
2014-07-28 16:53     ` Davidlohr Bueso
2014-07-28 16:57       ` Peter Zijlstra
2014-07-28 17:19         ` Jason Low
2014-07-28 16:54     ` Peter Zijlstra
2014-07-28 17:49       ` Jason Low
2014-07-28 18:50         ` Peter Zijlstra
2014-07-28 21:02           ` Jason Low
2014-07-30 15:11   ` Jason Low
2014-07-28  5:18 ` [PATCH -tip/master 4/7] locking/mutex: Refactor optimistic spinning code Davidlohr Bueso
2014-07-28  9:08   ` Peter Zijlstra
2014-07-28 16:39     ` Jason Low
2014-07-28 16:41       ` Davidlohr Bueso
2014-07-29  2:55   ` [PATCH -tip/master v2] " Davidlohr Bueso
2014-07-29  3:41     ` Jason Low
2014-07-29  4:31       ` Davidlohr Bueso
2014-07-29  4:51   ` [PATCH -tip/master v3] " Davidlohr Bueso
2014-07-30 15:18   ` [PATCH -tip/master 4/7] " Jason Low
2014-07-28  5:18 ` [PATCH -tip/master 5/7] locking/mutex: Use MUTEX_SPIN_ON_OWNER when appropriate Davidlohr Bueso
2014-07-30 15:19   ` Jason Low
2014-07-28  5:18 ` [PATCH 6/7] locking: Move docs into Documentation/locking/ Davidlohr Bueso
2014-07-28  5:18 ` [PATCH -tip/master 7/7] Documentation: Update locking/mutex-design.txt disadvantages Davidlohr Bueso
2014-07-28 18:09   ` Jason Low

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406566175.2411.13.camel@j-VirtualBox \
    --to=jason.low2@hp.com \
    --cc=aswin@hp.com \
    --cc=davidlohr@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox