From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751271AbaGaNC2 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 31 Jul 2014 09:02:28 -0400
Received: from bedivere.hansenpartnership.com ([66.63.167.143]:51514 "EHLO
	bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1750853AbaGaNC0 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 31 Jul 2014 09:02:26 -0400
Message-ID: <1406811739.6957.20.camel@jarvis>
Subject: Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69
 kmem_cache_create+0x1a9/0x330()
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Mike Christie <michaelc@cs.wisc.edu>, poma <pomidorabelisima@gmail.com>,
        Vladimir Davydov <vdavydov@parallels.com>,
        Linux Kernel list <linux-kernel@vger.kernel.org>,
        Christoph Lameter <cl@linux.com>,
        Mailing-List fedora-kernel <kernel@lists.fedoraproject.org>,
        Paolo Bonzini <pbonzini@redhat.com>, linux-scsi@vger.kernel.org
Date: Thu, 31 Jul 2014 17:02:19 +0400
In-Reply-To: <20140730175958.GA30976@lst.de>
References: <53C8DF7F.5060707@gmail.com> <53C8FD95.5020302@gmail.com>
	 <20140718132104.GK27940@esperanza> <20140718141747.GA23272@lst.de>
	 <53C97D34.5040707@gmail.com>
	 <1405714046.30262.10.camel@dabdike.int.hansenpartnership.com>
	 <20140719164454.GA24530@lst.de> <53CCDFC3.5010802@gmail.com>
	 <20140726162102.GA7126@lst.de> <53D929C3.3040709@cs.wisc.edu>
	 <20140730175958.GA30976@lst.de>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.2 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2014-07-30 at 19:59 +0200, Christoph Hellwig wrote:
> On Wed, Jul 30, 2014 at 12:22:11PM -0500, Mike Christie wrote:
> > Some drivers like qla2xxx do not set proc_name. I think if 2 drivers
> > like that are loaded then you will hit some other warns/bugs in the kmem
> > cache setup code right?
> 
> Drivers have to opt into using their own caches by setting .cmd_size
> in the host template.  We could enforce they set ->proc_name for them,
> but I'd rather keep the amount of sanity checks low unless there's a real
> need.

OK, so lets send this through normal merge window then we get time to
see if there's a problem before the backport to stable happens.

James