From: Imre Deak <imre.deak@intel.com>
To: Ian Kumlien <ian.kumlien@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [BUG?] 3.16-rc6 ... at drivers/gpu/drm/i915/intel_pm.c:5997 intel_display_power_put+0x12d/0x160()
Date: Fri, 01 Aug 2014 16:16:59 +0300 [thread overview]
Message-ID: <1406899019.11706.9.camel@intelbox> (raw)
In-Reply-To: <1406843268.6143.1.camel@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2547 bytes --]
On Thu, 2014-07-31 at 23:47 +0200, Ian Kumlien wrote:
> On tor, 2014-07-31 at 14:39 +0300, Imre Deak wrote:
> > On Wed, 2014-07-30 at 22:52 +0200, Ian Kumlien wrote:
> > > Sorry for the delay, it's been damned hot - vacation is over and
> > > overtime has been all the rage at work...
> >
> > No problem, thanks for the feedback.
> >
> > > On fre, 2014-07-25 at 12:28 +0300, Imre Deak wrote:
> > > > On Thu, 2014-07-24 at 01:33 +0200, Ian Kumlien wrote:
> > > > > Try four, now including CC lists for the intel driver...
> > > >
> > > > Could you give a try to the 2 patches at:
> > > > https://patchwork.kernel.org/patch/4437061/
> > >
> > > Didn't quite get that it was two separate patches at first, but when i
> > > did i also spotted a v2 of the patch set.
> > >
> > > I applied:
> > > https://patchwork.kernel.org/patch/4648961/
> > > https://patchwork.kernel.org/patch/4648951/
> > >
> > > On to 3.16-rc7 (there was some fuzz but it applied fine)
> > >
> > > I didn't see any OOPS:es (didn't scroll around too much) but otoh the
> > > screen never turned off? (it's one of those silly mac things, the apple
> > > is still lit) and the machine doesn't "suspend/sleep" anymore.
> > >
> > > AFAIR it does, after some coaxing, on the unpatched kernel (ie, not the
> > > first time but the second time i turn down the lid, i tried three times
> > > and play:ed with brightness as i assume you can see in the log)
> >
> > Hm, I can't see how these patches could prevent system suspend. Also
> > according to the dmesg you sent suspend didn't even start, so I guess
> > you're seeing a separate issue. Maybe the lid notification isn't
> > properly handled, but I can't really help tracking that down.
>
> It works without the drm.debug=14 so it might be something else...
>
> > In any case to reproduce the particular bug in question (or see if the
> > fix works) you need to get the machine to suspend/resume somehow. One
> > way is to 'echo mem > /sys/power/state' as root and resume by pressing
> > power button or similar; could you still try this, again sending the
> > dmesg?
>
> You'll find it attached ;)
Ok, I see the trace of suspend/resume now, but the bug has vanished.. I
can't see the WARN backtrace in your original report, nor the debug
message from the above fix, that would indicate that it had fixed
anything ("VDD left on by BIOS, adjusting state tracking"). So I'm a bit
lost, I would need a full dmesg with either the WARN or this debug
message.
--Imre
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2014-08-01 13:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 23:33 [BUG?] 3.16-rc6 ... at drivers/gpu/drm/i915/intel_pm.c:5997 intel_display_power_put+0x12d/0x160() Ian Kumlien
2014-07-25 9:28 ` [Intel-gfx] " Imre Deak
2014-07-25 10:10 ` Ian Kumlien
2014-07-30 20:52 ` Ian Kumlien
2014-07-31 11:39 ` Imre Deak
2014-07-31 21:47 ` Ian Kumlien
2014-08-01 13:16 ` Imre Deak [this message]
2014-08-01 13:28 ` Ian Kumlien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406899019.11706.9.camel@intelbox \
--to=imre.deak@intel.com \
--cc=ian.kumlien@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).