From: "Devin J. Pohly" <djpohly@gmail.com>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
"Devin J. Pohly" <djpohly+linux@gmail.com>
Subject: [PATCH 1/1] kbuild: use $(srctree) to locate config headers from external modules
Date: Fri, 1 Aug 2014 15:47:23 -0400 [thread overview]
Message-ID: <1406922443-22770-1-git-send-email-djpohly+linux@gmail.com> (raw)
When making modules_install for an out-of-tree module, the current
directory is $(KBUILD_OUTPUT), and the Makefile recipe which verifies
the existence of files in include/config is unable to find them using a
relative path. This leads to a spurious and puzzling "Kernel
configuration is invalid" warning when no configuration is actually
needed.
Since the file check is done in a recipe with `test -e' rather than as a
target or include, the usual search paths provided by VPATH and -I are
not consulted, so an explicit path is needed in this case.
Signed-off-by: Devin J. Pohly <djpohly+linux@gmail.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index f6a7794..60c14a2 100644
--- a/Makefile
+++ b/Makefile
@@ -590,7 +590,7 @@ else
PHONY += include/config/auto.conf
include/config/auto.conf:
- $(Q)test -e include/generated/autoconf.h -a -e $@ || ( \
+ $(Q)test -e $(srctree)/include/generated/autoconf.h -a -e $(srctree)/$@ || ( \
echo >&2; \
echo >&2 " ERROR: Kernel configuration is invalid."; \
echo >&2 " include/generated/autoconf.h or $@ are missing.";\
--
2.0.3
next reply other threads:[~2014-08-01 19:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 19:47 Devin J. Pohly [this message]
2014-08-04 14:10 ` [PATCH 1/1] kbuild: use $(srctree) to locate config headers from external modules Michal Marek
2014-08-04 14:43 ` Devin J. Pohly
2014-08-04 14:53 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406922443-22770-1-git-send-email-djpohly+linux@gmail.com \
--to=djpohly@gmail.com \
--cc=djpohly+linux@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).