[PATCH 1/2] gpu: ipu-v3: Select GENERIC_IRQ_CHIP to fix build error

[PATCH 1/2] gpu: ipu-v3: Select GENERIC_IRQ_CHIP to fix build error

[Axel Lin]

This driver uses GENERIC_IRQ_CHIP, so it needs to select GENERIC_IRQ_CHIP to
avoid build error.

Fixes below build errors:
ERROR: "irq_alloc_domain_generic_chips" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_gc_mask_clr_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_gc_mask_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_generic_chip_ops" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_gc_ack_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_get_domain_generic_chip" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/gpu/ipu-v3/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/ipu-v3/Kconfig b/drivers/gpu/ipu-v3/Kconfig
index 2f228a2..01864a5 100644
--- a/drivers/gpu/ipu-v3/Kconfig
+++ b/drivers/gpu/ipu-v3/Kconfig
@@ -2,6 +2,7 @@ config IMX_IPUV3_CORE
 	tristate "IPUv3 core support"
 	depends on SOC_IMX5 || SOC_IMX6Q || SOC_IMX6SL || ARCH_MULTIPLATFORM
 	depends on RESET_CONTROLLER
+	select GENERIC_IRQ_CHIP
 	help
 	  Choose this if you have a i.MX5/6 system and want to use the Image
 	  Processing Unit. This option only enables IPU base support.
-- 
1.9.1

[PATCH 2/2] gpu: ipu-v3: Return proper error on ipu_add_client_devices error path

[Axel Lin]

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/gpu/ipu-v3/ipu-common.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c
index 04e7b2e..e340beb 100644
--- a/drivers/gpu/ipu-v3/ipu-common.c
+++ b/drivers/gpu/ipu-v3/ipu-common.c
@@ -1116,8 +1116,10 @@ static int ipu_add_client_devices(struct ipu_soc *ipu, unsigned long ipu_base)
 				id++, &reg->pdata, sizeof(reg->pdata));
 		}
 
-		if (IS_ERR(pdev))
+		if (IS_ERR(pdev)) {
+			ret = PTR_ERR(pdev);
 			goto err_register;
+		}
 	}
 
 	return 0;
-- 
1.9.1

Re: [PATCH 1/2] gpu: ipu-v3: Select GENERIC_IRQ_CHIP to fix build error

[Axel Lin]

2014-08-03 10:36 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
> This driver uses GENERIC_IRQ_CHIP, so it needs to select GENERIC_IRQ_CHIP to
> avoid build error.
>
> Fixes below build errors:
> ERROR: "irq_alloc_domain_generic_chips" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> ERROR: "irq_gc_mask_clr_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> ERROR: "irq_gc_mask_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> ERROR: "irq_generic_chip_ops" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> ERROR: "irq_gc_ack_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> ERROR: "irq_get_domain_generic_chip" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2

Hi Greg,

I still hit this build error in today's linuex-next tree with below config:
ARCH_MULTIPLATFORM && !SOC_IMX5 && !SOC_IMX6Q && !SOC_IMX6SL

This driver just moved from staging to gpu.
So it's not clear to me who will pick up this patch.
Can you pick up this patch?

Thanks,
Axel

Re: [PATCH 1/2] gpu: ipu-v3: Select GENERIC_IRQ_CHIP to fix build error

[Greg Kroah-Hartman]

On Tue, Sep 02, 2014 at 09:47:37AM +0800, Axel Lin wrote:
> 2014-08-03 10:36 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
> > This driver uses GENERIC_IRQ_CHIP, so it needs to select GENERIC_IRQ_CHIP to
> > avoid build error.
> >
> > Fixes below build errors:
> > ERROR: "irq_alloc_domain_generic_chips" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> > ERROR: "irq_gc_mask_clr_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> > ERROR: "irq_gc_mask_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> > ERROR: "irq_generic_chip_ops" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> > ERROR: "irq_gc_ack_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> > ERROR: "irq_get_domain_generic_chip" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> > make[1]: *** [__modpost] Error 1
> > make: *** [modules] Error 2
> 
> Hi Greg,
> 
> I still hit this build error in today's linuex-next tree with below config:
> ARCH_MULTIPLATFORM && !SOC_IMX5 && !SOC_IMX6Q && !SOC_IMX6SL
> 
> This driver just moved from staging to gpu.
> So it's not clear to me who will pick up this patch.
> Can you pick up this patch?

As the code isn't in the staging tree, why shouldn't it go through the
drivers/gpu/* maintainer?

thanks,

greg k-h

Re: [PATCH 1/2] gpu: ipu-v3: Select GENERIC_IRQ_CHIP to fix build error

[Axel Lin]

2014-09-02 10:11 GMT+08:00 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> On Tue, Sep 02, 2014 at 09:47:37AM +0800, Axel Lin wrote:
>> 2014-08-03 10:36 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
>> > This driver uses GENERIC_IRQ_CHIP, so it needs to select GENERIC_IRQ_CHIP to
>> > avoid build error.
>> >
>> > Fixes below build errors:
>> > ERROR: "irq_alloc_domain_generic_chips" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
>> > ERROR: "irq_gc_mask_clr_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
>> > ERROR: "irq_gc_mask_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
>> > ERROR: "irq_generic_chip_ops" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
>> > ERROR: "irq_gc_ack_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
>> > ERROR: "irq_get_domain_generic_chip" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
>> > make[1]: *** [__modpost] Error 1
>> > make: *** [modules] Error 2
>>
>> Hi Greg,
>>
>> I still hit this build error in today's linuex-next tree with below config:
>> ARCH_MULTIPLATFORM && !SOC_IMX5 && !SOC_IMX6Q && !SOC_IMX6SL
>>
>> This driver just moved from staging to gpu.
>> So it's not clear to me who will pick up this patch.
>> Can you pick up this patch?
>
> As the code isn't in the staging tree, why shouldn't it go through the
> drivers/gpu/* maintainer?

scripts/get_maintainer.pl
sent/0001-gpu-ipu-v3-select-GENERIC_IRQ_CHIP-to-fix-build-erro.patch
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (commit_signer:1/1=100%)
Lucas Stach <l.stach@pengutronix.de> (commit_signer:1/1=100%)
Philipp Zabel <p.zabel@pengutronix.de>
(commit_signer:1/1=100%,authored:1/1=100%,added_lines:7/7=100%)
linux-kernel@vger.kernel.org (open list)

I checked the MAINTAINERS file,
I can only find the maintainer for some subfolders of drivers/gpu but no entry
for drivers/gpu/ipu-v3.
So I'm not sure who is the maintainer for drivers/gpu/ipu-v3.

Thanks,
Axel

Re: [PATCH 1/2] gpu: ipu-v3: Select GENERIC_IRQ_CHIP to fix build error

[Greg Kroah-Hartman]

On Tue, Sep 02, 2014 at 10:25:55AM +0800, Axel Lin wrote:
> 2014-09-02 10:11 GMT+08:00 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> > On Tue, Sep 02, 2014 at 09:47:37AM +0800, Axel Lin wrote:
> >> 2014-08-03 10:36 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
> >> > This driver uses GENERIC_IRQ_CHIP, so it needs to select GENERIC_IRQ_CHIP to
> >> > avoid build error.
> >> >
> >> > Fixes below build errors:
> >> > ERROR: "irq_alloc_domain_generic_chips" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> >> > ERROR: "irq_gc_mask_clr_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> >> > ERROR: "irq_gc_mask_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> >> > ERROR: "irq_generic_chip_ops" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> >> > ERROR: "irq_gc_ack_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> >> > ERROR: "irq_get_domain_generic_chip" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> >> > make[1]: *** [__modpost] Error 1
> >> > make: *** [modules] Error 2
> >>
> >> Hi Greg,
> >>
> >> I still hit this build error in today's linuex-next tree with below config:
> >> ARCH_MULTIPLATFORM && !SOC_IMX5 && !SOC_IMX6Q && !SOC_IMX6SL
> >>
> >> This driver just moved from staging to gpu.
> >> So it's not clear to me who will pick up this patch.
> >> Can you pick up this patch?
> >
> > As the code isn't in the staging tree, why shouldn't it go through the
> > drivers/gpu/* maintainer?
> 
> scripts/get_maintainer.pl
> sent/0001-gpu-ipu-v3-select-GENERIC_IRQ_CHIP-to-fix-build-erro.patch
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> (commit_signer:1/1=100%)
> Lucas Stach <l.stach@pengutronix.de> (commit_signer:1/1=100%)
> Philipp Zabel <p.zabel@pengutronix.de>
> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:7/7=100%)
> linux-kernel@vger.kernel.org (open list)
> 
> I checked the MAINTAINERS file,
> I can only find the maintainer for some subfolders of drivers/gpu but no entry
> for drivers/gpu/ipu-v3.
> So I'm not sure who is the maintainer for drivers/gpu/ipu-v3.

Who moved the file out of staging?  I don't think it was me...

I think it is Philipp, who sent the patches through the drm tree, so try
those developers.

thanks,

greg k-h

Re: [PATCH 1/2] gpu: ipu-v3: Select GENERIC_IRQ_CHIP to fix build error

[Philipp Zabel]

Hi,

Am Montag, den 01.09.2014, 20:28 -0700 schrieb Greg Kroah-Hartman:
[...]
> > I checked the MAINTAINERS file,
> > I can only find the maintainer for some subfolders of drivers/gpu but no entry
> > for drivers/gpu/ipu-v3.
> > So I'm not sure who is the maintainer for drivers/gpu/ipu-v3.
> 
> Who moved the file out of staging?  I don't think it was me...
>
> I think it is Philipp, who sent the patches through the drm tree, so try
> those developers.

I'll collect gpu/ipu-v3 patches and send them on.
I've pushed this patch to:

git://git.pengutronix.de/git/pza/linux.git topic/ipu-fixes

regards
Philipp