From: Michael Ellerman <mpe@ellerman.id.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andrey Utkin <andrey.krieger.utkin@gmail.com>,
paulus@samba.org, akpm@linux-foundation.org,
srivatsa.bhat@linux.vnet.ibm.com, sfr@canb.auug.org.au,
qiuxishi@huawei.com, wangyun@linux.vnet.ibm.com,
qiudayu@linux.vnet.ibm.com, joe@perches.com,
alistair@popple.id.au, rcj@linux.vnet.ibm.com,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] arch/powerpc/mm/numa.c: Fix break placement
Date: Tue, 05 Aug 2014 22:39:54 +1000 [thread overview]
Message-ID: <1407242394.11569.2.camel@concordia> (raw)
In-Reply-To: <1407230219.3073.5.camel@pasglop>
On Tue, 2014-08-05 at 19:16 +1000, Benjamin Herrenschmidt wrote:
> On Mon, 2014-08-04 at 23:13 +0300, Andrey Utkin wrote:
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=81631
> > Reported-by: David Binderman <dcb314@hotmail.com>
> > Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
>
> Thanks, I wonder how that managed to remain unnoticed for so long !
1. No one tested it :)
2. The code stupidly initialises ret at the beginning of the function, so the
compiler can't help us detect the unitialised usage.
3. NOTIFY_OK and NOTIFY_DONE appear to be equivalent in practice.
cheers
prev parent reply other threads:[~2014-08-05 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 20:13 [PATCH] arch/powerpc/mm/numa.c: Fix break placement Andrey Utkin
2014-08-05 9:16 ` Benjamin Herrenschmidt
2014-08-05 12:39 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407242394.11569.2.camel@concordia \
--to=mpe@ellerman.id.au \
--cc=akpm@linux-foundation.org \
--cc=alistair@popple.id.au \
--cc=andrey.krieger.utkin@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=qiudayu@linux.vnet.ibm.com \
--cc=qiuxishi@huawei.com \
--cc=rcj@linux.vnet.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=wangyun@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox