Re: [PATCH 1/1] dpt_i2o: delete unnecessary null test on array

walter harms
2014-08-08T14:38:37Z

Am 06.08.2014 12:39, schrieb Julia Lawall:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Delete NULL test on array (always false).
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> T [] e;
> position p;
> @@
> e ==@p NULL
>
> @ disable fld_to_ptr@
> expression e;
> identifier f;
> position r.p;
> @@
> * e.f ==@p NULL
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> I don't know if this is the correct change, or if some other test was
> intended. But the code has been this way since at least 2.4.20, so it
> would seem that no one has been bothered by the lack of whatever this was
> supposed to test for.
>
> drivers/scsi/dpt_i2o.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
> index 67283ef..62e276b 100644
> --- a/drivers/scsi/dpt_i2o.c
> +++ b/drivers/scsi/dpt_i2o.c
> @@ -1169,11 +1169,6 @@ static struct adpt_device* adpt_find_device(adpt_hba* pHba, u32 chan, u32 id, u6
> if(chan < 0 || chan >= MAX_CHANNEL)
> return NULL;
>

chan is u32 and u32 < 0 ?
for the next round.

re,
wh

> - if( pHba->channel[chan].device == NULL){
> - printk(KERN_DEBUG"Adaptec I2O RAID: Trying to find device before they are allocated\n");
> - return NULL;
> - }
> -
> d = pHba->channel[chan].device[id];
> if(!d || d->tid == 0) {
> return NULL;
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>